Paths

Table of Contentst

Differential D26881

lang/duktape and lang/duktape-lib: Update to 2.6.0
ClosedPublic
Actions

Authored by rhurlin on Oct 20 2020, 7:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 6, 6:16 AM

	Unknown Object (File)
	Sun, Nov 2, 7:43 PM

	Unknown Object (File)
	Sun, Nov 2, 7:43 PM

	Unknown Object (File)
	Sun, Nov 2, 7:43 PM

	Unknown Object (File)
	Sun, Nov 2, 3:06 PM

	Unknown Object (File)
	Tue, Oct 28, 11:34 AM

	Unknown Object (File)
	Sun, Oct 26, 1:22 AM

	Unknown Object (File)
	Sat, Oct 18, 4:32 AM

Subscribers

Details

Reviewers

arrowd
tcberner

Commits

rP552860: lang/duktape and lang/duktape-lib: Update to 2.6.0

Summary

Use CC and CFLAGS from ports framework
Don't install debug library
Bump PORTREVISION of www/edbrowse (has lang/duktape-lib as dependency)

Changelog: https://github.com/svaarala/duktape/blob/master/releases/releases.yaml

Submitted by <daniel.engberg.lists@pyret.net> in PRs 250358 and 250359

Tested on Poudriere (amd64, i386). 'portlint -AC' is ok.

Is it possible to reference the two PRs in one common svn commit?

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 34286
Build 31425: arc lint + arc unit

Event Timeline

rhurlin created this revision.Oct 20 2020, 7:30 PM

Herald added a subscriber: mat. · View Herald TranscriptOct 20 2020, 7:30 PM

rhurlin requested review of this revision.Oct 20 2020, 7:30 PM

Harbormaster completed remote builds in B34286: Diff 78517.Oct 20 2020, 7:30 PM

rhurlin edited the summary of this revision. (Show Details)Oct 20 2020, 7:34 PM

arrowd added inline comments.Oct 20 2020, 8:23 PM

lang/duktape-lib/Makefile
18	This looks like a value for `MAKE_ENV`, not `MAKE_ARGS`. Does that work?
lang/duktape/Makefile
16	Same here.

Is it possible to reference the two PRs in one common svn commit?

Sure:

PR: 123, 456

rhurlin added inline comments.Oct 20 2020, 8:42 PM

lang/duktape-lib/Makefile
18	As far as I know, it worked before. In this update, it will be removed in connection with the removal of `CC=gcc` in the patches of the sources Makefiles (`files/patch-Makefile.sharedlibrary` and `files/patch-Makefile.cmdline`). Now, system compiler should be used instead of GCC.

arrowd accepted this revision.Oct 21 2020, 7:48 AM

arrowd added inline comments.

lang/duktape-lib/Makefile
18	Ah, silly me. It is indeed removed, not added -_\

This revision is now accepted and ready to land.Oct 21 2020, 7:48 AM

Closed by commit rP552860: lang/duktape and lang/duktape-lib: Update to 2.6.0 (authored by rhurlin). · Explain WhyOct 21 2020, 10:26 AM

This revision was automatically updated to reflect the committed changes.

rhurlin added a commit: rP552860: lang/duktape and lang/duktape-lib: Update to 2.6.0.

Revision Contents
Changeset List

Path

Size

lang/

duktape-lib/

20 lines

6 lines

patch-Makefile.sharedlibrary

47 lines

duktape/

3 lines

6 lines

patch-Makefile.cmdline

12 lines

www/

edbrowse/

2 lines

Diff 78517

lang/duktape-lib/Makefile

Loading...

lang/duktape-lib/distinfo

Loading...

lang/duktape-lib/files/

Loading...

lang/duktape-lib/files/patch-Makefile.sharedlibrary

Loading...

lang/duktape/Makefile

Loading...

lang/duktape/distinfo

Loading...

lang/duktape/files/

Loading...

lang/duktape/files/patch-Makefile.cmdline

Loading...

www/edbrowse/Makefile

Loading...