Check TF_TOE not the tod pointer to determine if TOE is active.
ClosedPublic
Actions

Authored by jhb on Oct 15 2020, 6:48 PM.

Tags

None

Referenced Files

	F169992436: D26803.diff
	Thu, Sep 3, 5:10 AM

	F169882993: D26803.id.diff
	Wed, Sep 2, 9:19 PM

	Unknown Object (File)
	Wed, Sep 2, 7:14 AM

	Unknown Object (File)
	Mon, Aug 31, 8:08 PM

	Unknown Object (File)
	Mon, Aug 31, 7:24 AM

	Unknown Object (File)
	Mon, Aug 31, 2:34 AM

	Unknown Object (File)
	Sun, Aug 30, 1:32 AM

	Unknown Object (File)
	Sat, Aug 29, 4:16 PM

View All Files

Subscribers

imp

Details

Reviewers

Commits

rS366845: Check TF_TOE not the tod pointer to determine if TOE is active.

Summary

The TF_TOE flag is the check used in the rest of the network stack to
determine if TOE is active on a socket. There is at least one path in
the cxgbe(4) TOE driver that can leave the tod pointer non-NULL on a
socket not using TOE.

Test Plan

found by Chelsio QA, was not able to reproduce myself, but this seems like the right fix

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Oct 15 2020, 6:48 PM

jhb created this revision.

Harbormaster completed remote builds in B34193: Diff 78278.Oct 15 2020, 6:48 PM

np accepted this revision.Oct 19 2020, 5:29 PM

This revision is now accepted and ready to land.Oct 19 2020, 5:29 PM

Closed by commit rS366845: Check TF_TOE not the tod pointer to determine if TOE is active. (authored by jhb). · Explain WhyOct 19 2020, 6:24 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS366845: Check TF_TOE not the tod pointer to determine if TOE is active..

Herald added a subscriber: imp. · View Herald TranscriptOct 19 2020, 6:24 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

uipc_ktls.c

2 lines

Diff 78454

View Options

Check TF_TOE not the tod pointer to determine if TOE is active.ClosedPublicActions