Check TF_TOE not the tod pointer to determine if TOE is active.
ClosedPublic
Actions

Authored by jhb on Oct 15 2020, 6:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 21, 11:51 AM

	Unknown Object (File)
	Mon, Apr 20, 9:16 AM

	Unknown Object (File)
	Wed, Apr 15, 3:50 AM

	Unknown Object (File)
	Tue, Apr 14, 12:07 PM

	Unknown Object (File)
	Tue, Apr 14, 9:06 AM

	Unknown Object (File)
	Sat, Apr 11, 7:29 AM

	Unknown Object (File)
	Fri, Apr 10, 8:19 PM

	Unknown Object (File)
	Fri, Apr 10, 6:49 AM

View All 89 Files

Subscribers

imp

Details

Reviewers

Commits

rS366845: Check TF_TOE not the tod pointer to determine if TOE is active.

Summary

The TF_TOE flag is the check used in the rest of the network stack to
determine if TOE is active on a socket. There is at least one path in
the cxgbe(4) TOE driver that can leave the tod pointer non-NULL on a
socket not using TOE.

Test Plan

found by Chelsio QA, was not able to reproduce myself, but this seems like the right fix

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34193
Build 31344: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Oct 15 2020, 6:48 PM

jhb created this revision.

Harbormaster completed remote builds in B34193: Diff 78278.Oct 15 2020, 6:48 PM

np accepted this revision.Oct 19 2020, 5:29 PM

This revision is now accepted and ready to land.Oct 19 2020, 5:29 PM

Closed by commit rS366845: Check TF_TOE not the tod pointer to determine if TOE is active. (authored by jhb). · Explain WhyOct 19 2020, 6:24 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS366845: Check TF_TOE not the tod pointer to determine if TOE is active..

Herald added a subscriber: imp. · View Herald TranscriptOct 19 2020, 6:24 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

uipc_ktls.c

2 lines

Diff 78278

View Options

Check TF_TOE not the tod pointer to determine if TOE is active.ClosedPublicActions