Fix building on Linux/macOS after r366622
ClosedPublic
Actions

Authored by arichardson on Oct 11 2020, 12:27 PM.

Tags

None

Referenced Files

	F135751586: D26738.id.diff
	Wed, Nov 12, 12:01 PM

	F135748100: D26738.id.diff
	Wed, Nov 12, 11:08 AM

	Unknown Object (File)
	Tue, Nov 11, 7:19 PM

	Unknown Object (File)
	Tue, Nov 11, 6:01 PM

	Unknown Object (File)
	Tue, Nov 11, 4:17 PM

	Unknown Object (File)
	Mon, Nov 10, 6:30 PM

	Unknown Object (File)
	Wed, Oct 29, 7:29 PM

	Unknown Object (File)
	Wed, Oct 29, 7:28 PM

View All Files

Subscribers

imp

Details

Reviewers

cem

Commits

rS366632: Fix building on Linux/macOS after r366622

Summary

We have to bootstrap arc4random.c, so guard the FenestrasX code to avoid
using it on Linux/macOS.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34096
Build 31267: arc lint + arc unit

Event Timeline

arichardson created this revision.Oct 11 2020, 12:27 PM

Harbormaster completed remote builds in B34096: Diff 78102.Oct 11 2020, 12:27 PM

arichardson requested review of this revision.Oct 11 2020, 12:27 PM

arichardson mentioned this in D22839: random(4) fenestrasX: Push root seed version to arc4random(3).Oct 11 2020, 12:28 PM

Sure, seems fine to me.

This revision is now accepted and ready to land.Oct 11 2020, 4:36 PM

Closed by commit rS366632: Fix building on Linux/macOS after r366622 (authored by arichardson). · Explain WhyOct 12 2020, 10:42 AM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS366632: Fix building on Linux/macOS after r366622.

Herald added a subscriber: imp. · View Herald TranscriptOct 12 2020, 10:42 AM

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

arc4random.h

9 lines

arc4random.c

5 lines

Diff 78102

View Options

lib/libc/gen/arc4random.h