Page MenuHomeFreeBSD
Differential D1260

Add video user for drm devices
ClosedPublic
Actions

Authored by kwm on Dec 3 2014, 12:09 PM.
Tags
None
Referenced Files
F106185151: D1260.id2616.diff
Thu, Dec 26, 7:28 PM
Unknown Object (File)
Wed, Dec 11, 1:55 AM
Unknown Object (File)
Sun, Dec 1, 11:34 PM
Unknown Object (File)
Nov 25 2024, 3:33 AM
Unknown Object (File)
Nov 24 2024, 6:52 PM
Unknown Object (File)
Nov 10 2024, 5:00 PM
Unknown Object (File)
Nov 10 2024, 4:57 PM
Unknown Object (File)
Oct 22 2024, 7:28 AM
View All Files
Subscribers
allanjude
imp

Details

Reviewers
dumbbell
Commits
rS286524: Add a new group named 'video' with the id of 44. And make drm create
Summary

Make drm 1 and 2 create devices under /dev/dri which are owned by root:video.

I don't know if the group video GID is the correct value, we can always change it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kwm updated this revision to Diff 2616.Dec 3 2014, 12:09 PM
kwm retitled this revision from to Add video user for drm devices.
kwm updated this object.
kwm edited the test plan for this revision. (Show Details)
kwm added a reviewer: dumbbell.
kwm updated this object.
dumbbell edited edge metadata.Feb 7 2015, 11:51 AM

As discussed on IRC, GID 90 is already taken by firebird.

On Linux, there is no standard GID. Debian uses 44, Gentoo uses 27 for instance.

sys/dev/drm/drmP.h
184 ↗(On Diff #2616)

Please add a comment to recall the group name.

sys/dev/drm2/drmP.h
204 ↗(On Diff #2616)

Likewise.

kwm updated this revision to Diff 3684.Feb 7 2015, 1:41 PM
kwm edited edge metadata.

Use a unused GID, 90 is already in use in ports by firebird.
Add comment in drmP.h

dumbbell added a comment.Feb 7 2015, 1:56 PM

We need to document the change in UPDATING, just in case it conflicts with user-created groups.

I think there is no changes for the user otherwise. The X.Org server runs setuid root, so the group is irrelevant.

allanjude added a subscriber: allanjude.Jun 13 2015, 5:59 AM
dumbbell requested changes to this revision.Jun 16 2015, 10:15 AM
dumbbell edited edge metadata.

I repost my last comment, because I forgot to set the "Action" properly.

The comment was: we need to document the change in UPDATING, just in case it conflicts with user-created groups.

This revision now requires changes to proceed.Jun 16 2015, 10:15 AM
kwm updated this revision to Diff 6238.Jun 16 2015, 4:09 PM
kwm edited edge metadata.
kwm updated this object.

Add updating entry

Herald added a subscriber: imp. · View Herald TranscriptJun 16 2015, 4:09 PM
kwm updated this revision to Diff 7619.Aug 3 2015, 8:27 PM
kwm edited edge metadata.

Catch up with src changes.

dumbbell accepted this revision.Aug 3 2015, 10:06 PM
dumbbell edited edge metadata.
This revision is now accepted and ready to land.Aug 3 2015, 10:06 PM
kwm updated this revision to Diff 7800.Aug 9 2015, 12:06 PM
kwm edited edge metadata.

new UPDATING

This revision now requires review to proceed.Aug 9 2015, 12:06 PM
dumbbell requested changes to this revision.Aug 9 2015, 12:29 PM
dumbbell edited edge metadata.
dumbbell added inline comments.
UPDATING
38 ↗(On Diff #7800)

I would say:

If you want to (...)
40 ↗(On Diff #7800)

Instead of hard-coding your username, you could use:

# pw groupmod video -m $USER
This revision now requires changes to proceed.Aug 9 2015, 12:29 PM
kwm updated this revision to Diff 7803.Aug 9 2015, 12:33 PM
kwm edited edge metadata.

UPDATING tweaks

dumbbell accepted this revision.Aug 9 2015, 12:35 PM
dumbbell edited edge metadata.
This revision is now accepted and ready to land.Aug 9 2015, 12:35 PM
Closed by commit rS286524: Add a new group named 'video' with the id of 44. And make drm create (authored by kwm). · Explain WhyAug 9 2015, 12:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
8 lines
etc/
1 line
sys/
dev/
drm/
2 lines
drm2/
2 lines

Diff 7804

View Options

head/UPDATING

Loading...
View Options

head/etc/group

Loading...
View Options

head/sys/dev/drm/drmP.h

Loading...
View Options

head/sys/dev/drm2/drmP.h

Loading...