Avoid a dubious assignment to bio_data in aio_qbio().
ClosedPublic
Actions

Authored by jhb on Sep 29 2020, 9:14 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Aug 18, 8:21 PM

	Unknown Object (File)
	Tue, Aug 18, 7:59 PM

	Unknown Object (File)
	Tue, Aug 18, 4:34 PM

	Unknown Object (File)
	Tue, Aug 18, 8:28 AM

	Unknown Object (File)
	Tue, Aug 18, 5:01 AM

	Unknown Object (File)
	Mon, Aug 17, 2:17 PM

	Unknown Object (File)
	Mon, Aug 17, 6:07 AM

	Unknown Object (File)
	Sun, Aug 16, 7:15 PM

View All Files

Subscribers

imp

Details

Reviewers

kib

Commits

rS366296: Avoid a dubious assignment to bio_data in aio_qbio().

Summary

A user pointer is not a suitable value for bio_data and the next block
of code always overwrites bio_data anyway. Just use cb->aio_buf
directly in the call to vm_fault_quick_hold_pages().

Test Plan

kyua test -k /usr/tests/sys/aio/Kyuafile

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33886
Build 31093: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Sep 29 2020, 9:14 PM

jhb created this revision.

Harbormaster completed remote builds in B33886: Diff 77652.Sep 29 2020, 9:14 PM

kib accepted this revision.Sep 30 2020, 3:22 AM

This revision is now accepted and ready to land.Sep 30 2020, 3:22 AM

Closed by commit rS366296: Avoid a dubious assignment to bio_data in aio_qbio(). (authored by jhb). · Explain WhySep 30 2020, 5:49 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS366296: Avoid a dubious assignment to bio_data in aio_qbio()..

Herald added a subscriber: imp. · View Herald TranscriptSep 30 2020, 5:49 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_aio.c

3 lines

Diff 77652

View Options

Avoid a dubious assignment to bio_data in aio_qbio().ClosedPublicActions