Set AlignTrailingComments in the clang-format config
ClosedPublic
Actions

Authored by arichardson on Sep 10 2020, 1:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 6, 4:33 PM

	Unknown Object (File)
	Mon, Nov 25, 12:17 AM

	Unknown Object (File)
	Sat, Nov 23, 10:31 AM

	Unknown Object (File)
	Oct 21 2024, 8:26 AM

	Unknown Object (File)
	Oct 19 2024, 12:12 PM

	Unknown Object (File)
	Oct 5 2024, 9:59 PM

	Unknown Object (File)
	Oct 2 2024, 7:38 PM

	Unknown Object (File)
	Oct 2 2024, 2:25 PM

View All 87 Files

Subscribers

None

Details

Reviewers

emaste
imp

Commits

rS365576: Set AlignTrailingComments in the clang-format config

Summary

This seems to be fairly common in existing code and often looks better when
adding trailing comments to e.g. enumerators or array initializers.
See D26340 for more context.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33486
Build 30762: arc lint + arc unit

Event Timeline

arichardson requested review of this revision.Sep 10 2020, 1:38 PM

arichardson created this revision.

Harbormaster completed remote builds in B33484: Diff 76874.Sep 10 2020, 1:38 PM

correct diff

Harbormaster completed remote builds in B33486: Diff 76876.Sep 10 2020, 1:55 PM

I'm curious how well this works in practice (i.e., it's often difficult to simultaneously address aligned comments and line length limits) but this is probably the right choice.

This revision is now accepted and ready to land.Sep 10 2020, 1:56 PM

Closed by commit rS365576: Set AlignTrailingComments in the clang-format config (authored by arichardson). · Explain WhySep 10 2020, 2:11 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS365576: Set AlignTrailingComments in the clang-format config.