Set AlignTrailingComments in the clang-format config
ClosedPublic
Actions

Authored by arichardson on Sep 10 2020, 1:38 PM.

Tags

None

Referenced Files

	F137937334: D26391.diff
	Thu, Nov 27, 11:08 AM

	Unknown Object (File)
	Fri, Nov 14, 10:33 PM

	Unknown Object (File)
	Fri, Nov 14, 10:20 PM

	Unknown Object (File)
	Tue, Nov 4, 7:49 PM

	Unknown Object (File)
	Sat, Nov 1, 11:25 AM

	Unknown Object (File)
	Fri, Oct 31, 7:01 AM

	Unknown Object (File)
	Wed, Oct 29, 12:46 PM

	Unknown Object (File)
	Wed, Oct 29, 12:06 PM

View All Files

Subscribers

None

Details

Reviewers

emaste
imp

Commits

rS365576: Set AlignTrailingComments in the clang-format config

Summary

This seems to be fairly common in existing code and often looks better when
adding trailing comments to e.g. enumerators or array initializers.
See D26340 for more context.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33484
Build 30760: arc lint + arc unit

Event Timeline

arichardson requested review of this revision.Sep 10 2020, 1:38 PM

arichardson created this revision.

Harbormaster completed remote builds in B33484: Diff 76874.Sep 10 2020, 1:38 PM

correct diff

Harbormaster completed remote builds in B33486: Diff 76876.Sep 10 2020, 1:55 PM

I'm curious how well this works in practice (i.e., it's often difficult to simultaneously address aligned comments and line length limits) but this is probably the right choice.

This revision is now accepted and ready to land.Sep 10 2020, 1:56 PM

Closed by commit rS365576: Set AlignTrailingComments in the clang-format config (authored by arichardson). · Explain WhySep 10 2020, 2:11 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS365576: Set AlignTrailingComments in the clang-format config.