Fix -Wundef warnings when building liblua
ClosedPublic
Actions

Authored by arichardson on Aug 6 2020, 5:54 PM.

Tags

None

Referenced Files

	F164059627: D25977.id76201.diff
	Tue, Jul 28, 9:08 AM

	Unknown Object (File)
	Wed, Jul 22, 3:39 PM

	Unknown Object (File)
	Tue, Jul 14, 8:00 AM

	Unknown Object (File)
	Sat, Jul 11, 4:32 AM

	Unknown Object (File)
	Tue, Jul 7, 12:45 AM

	Unknown Object (File)
	Thu, Jul 2, 3:48 AM

	Unknown Object (File)
	Tue, Jun 30, 2:46 AM

	Unknown Object (File)
	Jun 12 2026, 4:52 PM

View All Files

Subscribers

None

Details

Reviewers

kevans
imp

Commits

rS364767: Fix -Wundef warnings when building liblua

Summary

We need to define the LUA_FLOAT_INT64 macro even if we don't use it (copied
from stand/luaconf.h). While touching luaconf.h.dist also sync it with the
the 5.3.5 release version (matches the one in lib/liblua).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson requested review of this revision.Aug 6 2020, 5:54 PM

arichardson created this revision.

Harbormaster completed remote builds in B32816: Diff 75513.Aug 6 2020, 5:54 PM

ping?

It's interesting, the luaconf.h used in lualoader *does* have these two definitions, and somehow the luaconf.h I hacked up for flua ended up with one but not the other?

Odd, but LGTM.

This revision is now accepted and ready to land.Aug 25 2020, 12:29 PM

Closed by commit rS364767: Fix -Wundef warnings when building liblua (authored by arichardson). · Explain WhyAug 25 2020, 1:30 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS364767: Fix -Wundef warnings when building liblua.