Page MenuHomeFreeBSD

Capsicumize fsck_ffs
Needs ReviewPublic

Authored by shubh on Aug 18 2020, 12:43 AM.
Referenced Files
F163142637: D26094.id.diff
Mon, Jul 20, 11:51 AM
Unknown Object (File)
Sun, Jul 12, 7:32 AM
Unknown Object (File)
Sat, Jul 11, 9:00 PM
Unknown Object (File)
Sun, Jul 5, 1:04 PM
Unknown Object (File)
Mon, Jun 29, 9:27 AM
Unknown Object (File)
Sun, Jun 28, 10:29 AM
Unknown Object (File)
May 21 2026, 12:03 PM
Unknown Object (File)
May 20 2026, 5:16 PM
Subscribers

Details

Reviewers
markj
oshogbo
Summary
  • Entered the capability mode after the setup() call is finished, because the setup() call is used in fsck_msdosfs, and hence it could interfere
  • Leveraged cap_pwd and cap_sysctl
  • Testing sysctl calls was tough, hence used the casper equivalents for all of them
Test Plan
  • Tamper a filesystem using fsdb, then test fsck_ffs

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sbin/fsck_ffs/dir.c
54

Maybe include it in fsck.h with casper.

sbin/fsck_ffs/fsck.h
297

extra line.

sbin/fsck_ffs/main.c
762

Maybe casper_init?

778

This style look weired.

782

Hym does it works? You limit to one sysctl name and then used with multiple diffrent names like:
vfs.ffs.setcwd, vfs.ffs.setdotdot.