Fix -Wundef warnings when building liblua
ClosedPublic
Actions

Authored by arichardson on Aug 6 2020, 5:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 13, 4:53 PM

	Unknown Object (File)
	Thu, Dec 4, 9:01 PM

	Unknown Object (File)
	Thu, Dec 4, 12:05 AM

	Unknown Object (File)
	Nov 27 2025, 4:52 PM

	Unknown Object (File)
	Nov 14 2025, 12:56 AM

	Unknown Object (File)
	Nov 13 2025, 11:33 PM

	Unknown Object (File)
	Nov 13 2025, 11:16 AM

	Unknown Object (File)
	Nov 13 2025, 7:22 AM

View All Files

Subscribers

None

Details

Reviewers

kevans
imp

Commits

rS364767: Fix -Wundef warnings when building liblua

Summary

We need to define the LUA_FLOAT_INT64 macro even if we don't use it (copied
from stand/luaconf.h). While touching luaconf.h.dist also sync it with the
the 5.3.5 release version (matches the one in lib/liblua).

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32816
Build 30231: arc lint + arc unit

Event Timeline

arichardson requested review of this revision.Aug 6 2020, 5:54 PM

arichardson created this revision.

Harbormaster completed remote builds in B32816: Diff 75513.Aug 6 2020, 5:54 PM

ping?

It's interesting, the luaconf.h used in lualoader *does* have these two definitions, and somehow the luaconf.h I hacked up for flua ended up with one but not the other?

Odd, but LGTM.

This revision is now accepted and ready to land.Aug 25 2020, 12:29 PM

Closed by commit rS364767: Fix -Wundef warnings when building liblua (authored by arichardson). · Explain WhyAug 25 2020, 1:30 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rS364767: Fix -Wundef warnings when building liblua.