Differential D25806

Add support for SOUND_MIXER_WRITE_MONITOR ioctl
ClosedPublic
Actions

Authored by trasz on Jul 25 2020, 7:07 PM.

Details

Reviewers

emaste

Group Reviewers

Linux Emulation

Commits

rS365833: Add support for SOUND_MIXER_WRITE_MONITOR ioctl. Fixes alsamixer(1)

Summary

Add support for SOUND_MIXER_WRITE_MONITOR ioctl. Fixes alsamixer(1)
on my x220.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32565
Build 30029: arc lint + arc unit

Event Timeline

trasz created this revision.Jul 25 2020, 7:07 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 25 2020, 7:07 PM

trasz requested review of this revision.Jul 25 2020, 7:07 PM

Harbormaster completed remote builds in B32541: Diff 74928.Jul 25 2020, 7:07 PM

trasz added a reviewer: Linux Emulation.Jul 25 2020, 7:07 PM

emaste added a subscriber: emaste.Jul 25 2020, 8:38 PM

emaste added inline comments.

sys/compat/linux/linux_ioctl.c
1796	probably don't want to leave this?

Remove debugging printf.

Harbormaster completed remote builds in B32565: Diff 74968.Jul 26 2020, 5:11 PM

(Tinderboxed.)

Seems OK

This revision is now accepted and ready to land.Sep 5 2020, 4:15 PM

Closed by commit rS365833: Add support for SOUND_MIXER_WRITE_MONITOR ioctl. Fixes alsamixer(1) (authored by trasz). · Explain WhySep 17 2020, 11:45 AM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rS365833: Add support for SOUND_MIXER_WRITE_MONITOR ioctl. Fixes alsamixer(1).

Revision Contents
Changeset List

Path

Size

sys/

compat/

linux/

linux_ioctl.h

1 line

linux_ioctl.c

4 lines

Diff 74968

View Options

sys/compat/linux/linux_ioctl.h