Differential D8700

Use ${PKG_BIN} instead of hard-coded pkg command
ClosedPublic
Actions

Authored by tgyurci_gmail.com on Dec 3 2016, 10:42 PM.

Tags

None

Referenced Files

	F173360532: D8700.id22687.diff
	Fri, Sep 25, 10:57 AM

	F173360391: D8700.id22718.diff
	Fri, Sep 25, 10:55 AM

	F173360290: D8700.id22697.diff
	Fri, Sep 25, 10:54 AM

	F173360172: D8700.id74757.diff
	Fri, Sep 25, 10:53 AM

	F173348732: D8700.diff
	Fri, Sep 25, 9:21 AM

	Unknown Object (File)
	Mon, Sep 21, 9:21 PM

	Unknown Object (File)
	Mon, Sep 21, 9:18 PM

	Unknown Object (File)
	Mon, Sep 21, 9:16 PM

Subscribers

Contributor Reviewers (ports)

Details

Reviewers

bapt
mat

Group Reviewers

O5: Ports Framework
portmgr

Commits

rP542782: Use macro PKG_QUERY instead of hardcoded pkg query

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tgyurci_gmail.com updated this revision to Diff 22687.Dec 3 2016, 10:42 PM

tgyurci_gmail.com retitled this revision from to Use ${PKG_BIN} instead of hard-coded pkg command.

tgyurci_gmail.com updated this object.

tgyurci_gmail.com edited the test plan for this revision. (Show Details)

tgyurci_gmail.com set the repository for this revision to rP FreeBSD ports repository.

Owners added a reviewer: O5: Ports Framework.Dec 3 2016, 10:42 PM

Herald added a reviewer: portmgr. · View Herald TranscriptDec 3 2016, 10:42 PM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald Transcript

bapt accepted this revision.Dec 3 2016, 11:04 PM

bapt added a reviewer: bapt.

mat requested changes to this revision.Dec 4 2016, 12:33 AM

mat added a reviewer: mat.

mat added inline comments.

Scripts/qa.sh
12–16 ↗	(On Diff #22687)	This is not needed, the only possible usage of this script is through b.ports.m and it has the required environment variable.

This revision now requires changes to proceed.Dec 4 2016, 12:33 AM

I removed PKG_BIN from QA_ENV too

PKG_BIN should be in QA_ENV for qa.sh.

tgyurci_gmail.com marked an inline comment as done.Dec 5 2016, 9:53 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 21 2020, 7:16 PM

Closed by commit rP542782: Use macro PKG_QUERY instead of hardcoded pkg query (authored by bapt). · Explain Why

This revision was automatically updated to reflect the committed changes.

bapt added a commit: rP542782: Use macro PKG_QUERY instead of hardcoded pkg query.

Revision Contents
Changeset List

Path

Size

Packages

head/

Mk/

Uses/

2 lines

O5: Ports Framework

Diff 74757

head/Mk/Uses/ncurses.mk

Loading...