Don't imply that all action values can be OR'd.
ClosedPublic
Actions

Authored by brooks on Jul 13 2020, 11:32 PM.

Tags

None

Referenced Files

	F137811909: D25659.diff
	Wed, Nov 26, 1:23 AM

	F137811902: D25659.diff
	Wed, Nov 26, 1:23 AM

	Unknown Object (File)
	Sun, Nov 9, 4:09 AM

	Unknown Object (File)
	Mon, Nov 3, 12:48 AM

	Unknown Object (File)
	Thu, Oct 30, 7:42 AM

	Unknown Object (File)
	Oct 26 2025, 10:34 PM

	Unknown Object (File)
	Oct 26 2025, 5:18 AM

	Unknown Object (File)
	Oct 24 2025, 5:06 PM

View All 78 Files

Subscribers

None

Details

Reviewers

imp

Group Reviewers

manpages

Commits

rS363434: MFC r363228:
rS363432: MFC r363228:
rS363228: Don't imply that all action values can be OR'd.

Summary

This is neither POSIX compliant nor what the implementation does.
This could be allowed by changing the value of TCSAFLUSH from 2 to 3,
but that doesn't seem worthwhile after 25+ years.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32307
Build 29791: arc lint + arc unit

Event Timeline

brooks requested review of this revision.Jul 13 2020, 11:32 PM

brooks created this revision.

Harbormaster completed remote builds in B32307: Diff 74424.Jul 13 2020, 11:32 PM

imp accepted this revision.Jul 13 2020, 11:38 PM

This revision is now accepted and ready to land.Jul 13 2020, 11:38 PM

brooks added a reviewer: manpages.Jul 13 2020, 11:53 PM

Closed by commit rS363228: Don't imply that all action values can be OR'd. (authored by brooks). · Explain WhyJul 15 2020, 5:05 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rS363228: Don't imply that all action values can be OR'd..

brooks added a commit: rS363432: MFC r363228:.Jul 22 2020, 9:06 PM

brooks added a commit: rS363434: MFC r363228:.Jul 22 2020, 9:30 PM

Revision Contents
Changeset List

Path

Size

lib/

libc/

gen/

tcsetattr.3

21 lines

Diff 74424

View Options

Don't imply that all action values can be OR'd.ClosedPublicActions