Details

Reviewers

lwhsu
philip
lbartoletti

Group Reviewers

riscv

Commits

rP540833: sysutils/opensbi: update to v0.8

Summary

This brings some restructuring to the installation paths. Firmware
files are still stored under /usr/local/share, but with the new prefix
allowing for multiple ABIs to be installed (e.g. opensbi/lp64/qemu/virt).
Libraries have been moved to /usr/local/lib64.

A new "generic" platform has been added, which will produce firmware
binaries capable of running on several platforms. The qemu/virt and
spike platforms have been removed as a result.

Additionally, the fw_payload.[bin|elf] files will no longer be
installed. These are compiled with the test payload and therefore don't
offer much use as part of this port.

Test Plan

Builds in poudriere. Passes portlint -C.

Tested with qemu virt, qemu sifive_u, and spike.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne requested review of this revision.May 2 2020, 12:29 AM

mhorne created this revision.

Harbormaster completed remote builds in B30857: Diff 71264.May 2 2020, 12:29 AM

@lwhsu this update will likely affect CI, as the QEMU firmware file has been moved from /usr/local/share/opensbi/platform/qemu/virt/firmware/fw_jump.elf to /usr/local/share/opensbi/lp64/qemu/virt/firmware/fw_jump.elf. It looks like v0.8 will change this again, as the qemu/virt platform may be dropped in favor of a new generic platform. You might consider providing -bios default as an argument to QEMU instead, and this will use the version of OpenSBI shipped with QEMU.

At first glance, this looks good.

I'll test this out on my HiFive board this afternoon (UTC+8).

In D24660#542857, @philip wrote:

At first glance, this looks good.

I'll test this out on my HiFive board this afternoon (UTC+8).

Thanks. You will need r360554 or later to avoid hanging with this version.

@philip did you have a chance to test this yet? I hope to commit later this week. I will MFC the required changes for booting to stable/12 before I do.