Warning patches for clang
ClosedPublic
Actions

Authored by sbruno on Jul 16 2014, 1:45 PM.

Details

Reviewers

Summary

remove irrelevant checks for < 0 for unsigned variables

dfixed_trunc is a bitwise shift operator on a struct fixed20_12 "full" element.

full is defined as a u32, so it can't ever be less than 0 and these checks are pointless and simply spew warnings during compilation.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

sbruno updated this revision to Diff 733.Jul 16 2014, 1:45 PM

sbruno retitled this revision from to Warning patches for clang dfixed_trunc is a bitwise shift operator on a struct fixed20_12 "full" element. full is defined as a u32, so it can't ever be less than 0 and these checks are pointless and simply spew warnings during compilation..

sbruno updated this object.

sbruno added a reviewer: dumbbell.

sbruno retitled this revision from Warning patches for clang dfixed_trunc is a bitwise shift operator on a struct fixed20_12 "full" element. full is defined as a u32, so it can't ever be less than 0 and these checks are pointless and simply spew warnings during compilation. to Warning patches for clang.Jul 16 2014, 1:51 PM

sbruno updated this object.

This problem was already fixed by OpenBSD and submitted to Linux. Please see the upstream patch:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=1cd73ff7

te our code has "#ifdef DUMBBELL_WIP" around the first patch.
Probably dumbbell hacked it to work around the first problem. ;-)

Jung-uk Kim

I'm ok with the patch: feel free to commit it to -CURRENT. I will merge it in my development branch.

This revision is now accepted and ready to land.Jul 17 2014, 8:40 PM

Committed to freebsd head at svn R268954

Revision Contents
Changeset List

Path

Size

sys/

dev/

drm2/

radeon/

rs690.c

8 lines

rv515.c

8 lines

Diff 733

View Options

sys/dev/drm2/radeon/rs690.c