Simplify hot-patching cpu_switch() for lack of UserLocal register.
ClosedPublic
Actions

Authored by jhb on May 20 2020, 5:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 7 2024, 9:20 PM

	Unknown Object (File)
	Nov 21 2024, 10:02 AM

	Unknown Object (File)
	Oct 21 2024, 2:39 AM

	Unknown Object (File)
	Oct 15 2024, 2:39 AM

	Unknown Object (File)
	Oct 13 2024, 12:16 AM

	Unknown Object (File)
	Oct 4 2024, 4:58 PM

	Unknown Object (File)
	Oct 3 2024, 1:26 PM

	Unknown Object (File)
	Sep 30 2024, 7:47 AM

View All 53 Files

Subscribers

alfredo.mazzinghi_cl.cam.ac.uk

imp

Details

Reviewers

brooks
alfredo.mazzinghi_cl.cam.ac.uk

Commits

rS361296: Simplify hot-patching cpu_switch() for lack of UserLocal register.

Summary

Rather than walking all of cpu_switch looking for the sequence of
instructions to patch, add a global label at the location that needs
the patch applied.

Test Plan

booted mips64 under QEMU which does not implement UL and requires the hot patching to work

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31202
Build 28857: arc lint + arc unit

Event Timeline

jhb requested review of this revision.May 20 2020, 5:21 PM

jhb created this revision.

Harbormaster completed remote builds in B31202: Diff 72034.May 20 2020, 5:21 PM

Looks good to me.

This revision is now accepted and ready to land.May 20 2020, 5:53 PM

brooks accepted this revision.May 20 2020, 6:34 PM

Closed by commit rS361296: Simplify hot-patching cpu_switch() for lack of UserLocal register. (authored by jhb). · Explain WhyMay 20 2020, 9:16 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS361296: Simplify hot-patching cpu_switch() for lack of UserLocal register..

Herald added a subscriber: imp. · View Herald TranscriptMay 20 2020, 9:16 PM

Revision Contents
Changeset List

Path

Size

sys/

mips/

include/

md_var.h

1 line

mips/

cpu.c

55 lines

swtch.S

2 lines

Diff 72034

View Options

sys/mips/include/md_var.h

View Options

sys/mips/mips/cpu.c

View Options

Simplify hot-patching cpu_switch() for lack of UserLocal register.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 72034

sys/mips/include/md_var.h

sys/mips/mips/cpu.c

sys/mips/mips/swtch.S

Simplify hot-patching cpu_switch() for lack of UserLocal register.
ClosedPublic
Actions

Revision Contents
Changeset List