Page MenuHomeFreeBSD
Differential D24607

emulators/i386-wine-devel: Simplify PLIST variables
ClosedPublic
Actions

Authored by salvadore on Apr 28 2020, 7:05 PM.
Tags
None
Referenced Files
F160720396: D24607.id71121.diff
Sat, Jun 27, 4:11 AM
Unknown Object (File)
Mon, Jun 22, 9:37 PM
Unknown Object (File)
Mon, Jun 22, 8:42 PM
Unknown Object (File)
Sun, Jun 21, 10:03 PM
Unknown Object (File)
Sun, Jun 21, 5:43 AM
Unknown Object (File)
Sat, Jun 20, 7:30 PM
Unknown Object (File)
Sat, Jun 20, 1:53 AM
Unknown Object (File)
Fri, Jun 19, 2:38 PM
View All Files
Subscribers
mat

Details

Reviewers
gerald
tcberner
Commits
rP533267: emulators/i386-wine-devel: Simplify PLIST variables
Summary

Remove *DEVEL PLIST variables as they are now meaningless.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 30779
Build 28503: arc lint + arc unit

Event Timeline

salvadore created this revision.Apr 28 2020, 7:05 PM
Herald added a subscriber: mat. · View Herald TranscriptApr 28 2020, 7:05 PM
salvadore requested review of this revision.Apr 28 2020, 7:05 PM
Harbormaster completed remote builds in B30779: Diff 71121.Apr 28 2020, 7:05 PM
salvadore added a comment.EditedApr 28 2020, 7:07 PM

Sorry mentors: I missed those lines in the precedent commit.

tcberner accepted this revision.Apr 28 2020, 7:15 PM

lgtm

head/emulators/i386-wine-devel/Makefile.amd64
26

^ for the future, I would suggest, to use indentations for the if/for when nested, but that is not related to this review :)

.if foo
.  if bar

.  endif
.endif
This revision is now accepted and ready to land.Apr 28 2020, 7:15 PM
Closed by commit rP533267: emulators/i386-wine-devel: Simplify PLIST variables (authored by salvadore). · Explain WhyApr 28 2020, 9:05 PM
This revision was automatically updated to reflect the committed changes.
salvadore added a commit: rP533267: emulators/i386-wine-devel: Simplify PLIST variables.

Revision Contents
Changeset List

PathSize
head/
emulators/
i386-wine-devel/
8 lines

Diff 71121

View Options

head/emulators/i386-wine-devel/Makefile.amd64

Loading...