Alert devd when acpi_video brightness changes
ClosedPublic
Actions

Authored by cperciva on Apr 14 2020, 8:33 PM.

Details

Reviewers

imp
jkim

Commits

rS360025: Alert devd when acpi_video brightness changes

Summary

On my new Dell laptop, the brightness hotkeys (Fn+<up arrow> and Fn+<down arrow>) send ACPI notifications to acpi_video but the backlight brightness does not change. This patch makes acpi_video forward those notifications to devd, which allows me to invoke intel_backlight from userland.

Test Plan

Works for me. I'm posting this here in case because I'm not familiar with ACPI or devd and someone might tell me that I'm doing this wrong...

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 30504

Event Timeline

cperciva created this revision.Apr 14 2020, 8:33 PM

Harbormaster completed remote builds in B30504: Diff 70574.Apr 14 2020, 8:33 PM

imp accepted this revision.Apr 14 2020, 9:04 PM

This revision is now accepted and ready to land.Apr 14 2020, 9:04 PM

Closed by commit rS360025: Alert devd when acpi_video brightness changes (authored by cperciva). · Explain WhyApr 16 2020, 9:56 PM

This revision was automatically updated to reflect the committed changes.

cperciva added a commit: rS360025: Alert devd when acpi_video brightness changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

acpica/

acpi_video.c

3 lines

Diff 70574

View Options

sys/dev/acpica/acpi_video.c

Context not available.
	static void	static void
	vo_set_brightness(ACPI_HANDLE handle, int level)	vo_set_brightness(ACPI_HANDLE handle, int level)
	{	{
		char notify_buf[16];
	ACPI_STATUS status;	ACPI_STATUS status;

	ACPI_SERIAL_ASSERT(video_output);	ACPI_SERIAL_ASSERT(video_output);
Context not available.
	if (ACPI_FAILURE(status))	if (ACPI_FAILURE(status))
	printf("can't evaluate %s._BCM - %s\n",	printf("can't evaluate %s._BCM - %s\n",
	acpi_name(handle), AcpiFormatException(status));	acpi_name(handle), AcpiFormatException(status));
		snprintf(notify_buf, sizeof(notify_buf), "notify=%d", level);
		devctl_notify("ACPI", "Video", "brightness", notify_buf);
	}	}

	static UINT32	static UINT32
Context not available.

Alert devd when acpi_video brightness changesClosedPublicActions