Add my (rscheff) key
ClosedPublic
Actions

Authored by rscheff on Apr 9 2020, 11:38 AM.

Details

Reviewers

rgrimes
tuexen

Commits

rD54045: add my (rscheff) key

Summary

Add my (rscheff) key

Reviewed by:	rgrimes (mentor)
Approved by:	rgrimes (mentor)
MFC after:	3 days
Sponsored by:	NetApp, Inc.
Differential Revision:	https://reviews.freebsd.org/D24350

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 30387
Build 28152: arc lint + arc unit

Event Timeline

rscheff created this revision.Apr 9 2020, 11:38 AM

Harbormaster completed remote builds in B30387: Diff 70367.Apr 9 2020, 11:38 AM

rscheff retitled this revision from Add my(rscheff) key to Add my (rscheff) key.Apr 9 2020, 11:47 AM

rscheff edited the summary of this revision. (Show Details)

In commit messages other committers are refered to without the trailing @ sign. Other than that it looks good, I see you figured out the sorting order, but that file could defanitly use a linting

rscheff edited the summary of this revision. (Show Details)Apr 9 2020, 7:37 PM

tuexen accepted this revision.Apr 9 2020, 7:40 PM

This revision is now accepted and ready to land.Apr 9 2020, 7:40 PM

You don't have to update the reviewed by/accepted by lines in the reviews, just so long as you commit them with proper values.

Closed by commit rD54045: add my (rscheff) key (authored by rscheff). · Explain WhyApr 9 2020, 11:10 PM

This revision was automatically updated to reflect the committed changes.

rscheff added a commit: rD54045: add my (rscheff) key.