Page MenuHomeFreeBSD
Differential D3109

Enhance the *depends section with a note about :=
ClosedPublic
Actions

Authored by mat on Jul 16 2015, 3:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 6 2025, 7:41 AM
Unknown Object (File)
Mar 5 2025, 4:39 AM
Unknown Object (File)
Mar 2 2025, 12:08 PM
Unknown Object (File)
Feb 18 2025, 7:46 PM
Unknown Object (File)
Feb 8 2025, 7:50 PM
Unknown Object (File)
Feb 6 2025, 5:38 AM
Unknown Object (File)
Jan 31 2025, 3:41 AM
Unknown Object (File)
Jan 28 2025, 9:48 PM
View All 47 Files
Subscribers
None

Details

Reviewers
gjb
wblock
Commits
rD47032: Add a note saying not to use := in *_DEPENDS variables.
Summary

http://aragorn.in.absolight.net/d2/depends-bis/en_US.ISO8859-1/books/porters-handbook/makefile-depend.html

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

mat updated this revision to Diff 7021.Jul 16 2015, 3:23 PM
mat retitled this revision from to Enhance the *depends section with a note about :=.
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added reviewers: wblock, gjb.
mat updated this object.Jul 16 2015, 3:29 PM
wblock edited edge metadata.Jul 16 2015, 7:36 PM

This is good. Show the right way to do it, and then only after that tell (but do not show) the wrong way to do it.

en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
3295

Use <emphasis> around "Do not", or at least "not".

3299

Avoid the informal "you". For things that are not to be used, don't suggest that they might work some of the time.

All variables are expanded immediately, which is exactly the wrong thing to do and almost always a failure.

mat marked 2 inline comments as done.Jul 20 2015, 1:58 PM
mat added inline comments.
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
3295

I started with it, but <emphasis> puts stuff in italics, and an <important> block is already in italics, but you're right, I should not be tagging for rendering.

mat updated this revision to Diff 7098.Jul 20 2015, 1:59 PM
mat marked an inline comment as done.
mat edited edge metadata.

Update.

wblock accepted this revision.Jul 20 2015, 4:55 PM
wblock edited edge metadata.

Please remember to check with igor before commit. Thanks!

en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
3295

True. It does not render the <emphasis> stuff different from that around it, which is a stylesheet bug. That is something I'd like to fix, but not something I can look at immediately. gabor@ is probably the best person to contact.

This revision is now accepted and ready to land.Jul 20 2015, 4:55 PM
Closed by commit rD47032: Add a note saying not to use := in *_DEPENDS variables. (authored by mat). · Explain WhyJul 21 2015, 9:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
en_US.ISO8859-1/
books/
porters-handbook/
makefiles/
8 lines

Diff 7021

View Options

en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml

Show First 20 Lines • Show All 86 Lines • ▼ Show 20 Lines
static int tmpfs_root(struct mount *, int flags, struct vnode **); static int tmpfs_root(struct mount *, int flags, struct vnode **);
static int tmpfs_fhtovp(struct mount *, struct fid *, int, static int tmpfs_fhtovp(struct mount *, struct fid *, int,
struct vnode **); struct vnode **);
static int tmpfs_statfs(struct mount *, struct statfs *); static int tmpfs_statfs(struct mount *, struct statfs *);
static void tmpfs_susp_clean(struct mount *); static void tmpfs_susp_clean(struct mount *);
static const char *tmpfs_opts[] = { static const char *tmpfs_opts[] = {
"from", "size", "maxfilesize", "inodes", "uid", "gid", "mode", "export", "from", "size", "maxfilesize", "inodes", "uid", "gid", "mode", "export",
"union", "nonc", NULL "union", "nonc", "nomtime", NULL
}; };
static const char *tmpfs_updateopts[] = { static const char *tmpfs_updateopts[] = {
"from", "export", "size", NULL "from", "export", "nomtime", "size", NULL
}; };
/* /*
* Handle updates of time from writes to mmaped regions. Use * Handle updates of time from writes to mmaped regions, if allowed.
* MNT_VNODE_FOREACH_ALL instead of MNT_VNODE_FOREACH_LAZY, since * Use MNT_VNODE_FOREACH_ALL instead of MNT_VNODE_FOREACH_LAZY, since
* unmap of the tmpfs-backed vnode does not call vinactive(), due to * unmap of the tmpfs-backed vnode does not call vinactive(), due to
* vm object type is OBJT_SWAP. * vm object type is OBJT_SWAP. If lazy, only handle delayed update
markjUnsubmitted
Done
Inline Actions

This comment doesn't seem to be accurate anymore.

markj: This comment doesn't seem to be accurate anymore.
kibAuthorUnsubmitted
Done
Inline Actions

You mean that updates might be disabled ? I mentioned this. If you mean something else, please state.

kib: You mean that updates might be disabled ? I mentioned this. If you mean something else…
markjUnsubmitted
Not Done
Inline Actions

Sorry, I misunderstood what the comment was saying.

markj: Sorry, I misunderstood what the comment was saying.
* If lazy, only handle delayed update of mtime due to the writes to * of mtime due to the writes to mapped files.
* mapped files.
*/ */
static void static void
tmpfs_update_mtime(struct mount *mp, bool lazy) tmpfs_update_mtime(struct mount *mp, bool lazy)
{ {
struct vnode *vp, *mvp; struct vnode *vp, *mvp;
struct vm_object *obj; struct vm_object *obj;
if (VFS_TO_TMPFS(mp)->tm_nomtime)
return;
MNT_VNODE_FOREACH_ALL(vp, mp, mvp) { MNT_VNODE_FOREACH_ALL(vp, mp, mvp) {
if (vp->v_type != VREG) { if (vp->v_type != VREG) {
VI_UNLOCK(vp); VI_UNLOCK(vp);
continue; continue;
} }
obj = vp->v_object; obj = vp->v_object;
KASSERT((obj->flags & (OBJ_TMPFS_NODE | OBJ_TMPFS)) == KASSERT((obj->flags & (OBJ_TMPFS_NODE | OBJ_TMPFS)) ==
(OBJ_TMPFS_NODE | OBJ_TMPFS), ("non-tmpfs obj")); (OBJ_TMPFS_NODE | OBJ_TMPFS), ("non-tmpfs obj"));
▲ Show 20 Lines • Show All 198 Lines • ▼ Show 20 Lines
static int static int
tmpfs_mount(struct mount *mp) tmpfs_mount(struct mount *mp)
{ {
const size_t nodes_per_page = howmany(PAGE_SIZE, const size_t nodes_per_page = howmany(PAGE_SIZE,
sizeof(struct tmpfs_dirent) + sizeof(struct tmpfs_node)); sizeof(struct tmpfs_dirent) + sizeof(struct tmpfs_node));
struct tmpfs_mount *tmp; struct tmpfs_mount *tmp;
struct tmpfs_node *root; struct tmpfs_node *root;
int error; int error;
bool nonc; bool nomtime, nonc;
/* Size counters. */ /* Size counters. */
u_quad_t pages; u_quad_t pages;
off_t nodes_max, size_max, maxfilesize; off_t nodes_max, size_max, maxfilesize;
/* Root node attributes. */ /* Root node attributes. */
uid_t root_uid; uid_t root_uid;
gid_t root_gid; gid_t root_gid;
mode_t root_mode; mode_t root_mode;
struct vattr va; struct vattr va;
if (vfs_filteropt(mp->mnt_optnew, tmpfs_opts)) if (vfs_filteropt(mp->mnt_optnew, tmpfs_opts))
return (EINVAL); return (EINVAL);
if (mp->mnt_flag & MNT_UPDATE) { if (mp->mnt_flag & MNT_UPDATE) {
/* Only support update mounts for certain options. */ /* Only support update mounts for certain options. */
if (vfs_filteropt(mp->mnt_optnew, tmpfs_updateopts) != 0) if (vfs_filteropt(mp->mnt_optnew, tmpfs_updateopts) != 0)
return (EOPNOTSUPP); return (EOPNOTSUPP);
tmp = VFS_TO_TMPFS(mp);
if (vfs_getopt_size(mp->mnt_optnew, "size", &size_max) == 0) { if (vfs_getopt_size(mp->mnt_optnew, "size", &size_max) == 0) {
/* /*
* On-the-fly resizing is not supported (yet). We still * On-the-fly resizing is not supported (yet). We still
* need to have "size" listed as "supported", otherwise * need to have "size" listed as "supported", otherwise
* trying to update fs that is listed in fstab with size * trying to update fs that is listed in fstab with size
* parameter, say trying to change rw to ro or vice * parameter, say trying to change rw to ro or vice
* versa, would cause vfs_filteropt() to bail. * versa, would cause vfs_filteropt() to bail.
*/ */
if (size_max != VFS_TO_TMPFS(mp)->tm_size_max) if (size_max != tmp->tm_size_max)
return (EOPNOTSUPP); return (EOPNOTSUPP);
} }
if (vfs_flagopt(mp->mnt_optnew, "ro", NULL, 0) && if (vfs_flagopt(mp->mnt_optnew, "ro", NULL, 0) &&
!(VFS_TO_TMPFS(mp)->tm_ronly)) { !tmp->tm_ronly) {
/* RW -> RO */ /* RW -> RO */
return (tmpfs_rw_to_ro(mp)); return (tmpfs_rw_to_ro(mp));
} else if (!vfs_flagopt(mp->mnt_optnew, "ro", NULL, 0) && } else if (!vfs_flagopt(mp->mnt_optnew, "ro", NULL, 0) &&
VFS_TO_TMPFS(mp)->tm_ronly) { tmp->tm_ronly) {
/* RO -> RW */ /* RO -> RW */
VFS_TO_TMPFS(mp)->tm_ronly = 0; tmp->tm_ronly = 0;
MNT_ILOCK(mp); MNT_ILOCK(mp);
mp->mnt_flag &= ~MNT_RDONLY; mp->mnt_flag &= ~MNT_RDONLY;
MNT_IUNLOCK(mp); MNT_IUNLOCK(mp);
} }
tmp->tm_nomtime = vfs_flagopt(mp->mnt_optnew, "nomtime", NULL,
0) == 0;
return (0); return (0);
} }
vn_lock(mp->mnt_vnodecovered, LK_SHARED | LK_RETRY); vn_lock(mp->mnt_vnodecovered, LK_SHARED | LK_RETRY);
error = VOP_GETATTR(mp->mnt_vnodecovered, &va, mp->mnt_cred); error = VOP_GETATTR(mp->mnt_vnodecovered, &va, mp->mnt_cred);
VOP_UNLOCK(mp->mnt_vnodecovered); VOP_UNLOCK(mp->mnt_vnodecovered);
if (error) if (error)
return (error); return (error);
Show All 9 Lines if (mp->mnt_cred->cr_ruid != 0 ||
root_mode = va.va_mode; root_mode = va.va_mode;
if (vfs_getopt_size(mp->mnt_optnew, "inodes", &nodes_max) != 0) if (vfs_getopt_size(mp->mnt_optnew, "inodes", &nodes_max) != 0)
nodes_max = 0; nodes_max = 0;
if (vfs_getopt_size(mp->mnt_optnew, "size", &size_max) != 0) if (vfs_getopt_size(mp->mnt_optnew, "size", &size_max) != 0)
size_max = 0; size_max = 0;
if (vfs_getopt_size(mp->mnt_optnew, "maxfilesize", &maxfilesize) != 0) if (vfs_getopt_size(mp->mnt_optnew, "maxfilesize", &maxfilesize) != 0)
maxfilesize = 0; maxfilesize = 0;
nonc = vfs_getopt(mp->mnt_optnew, "nonc", NULL, NULL) == 0; nonc = vfs_getopt(mp->mnt_optnew, "nonc", NULL, NULL) == 0;
nomtime = vfs_getopt(mp->mnt_optnew, "nomtime", NULL, NULL) == 0;
/* Do not allow mounts if we do not have enough memory to preserve /* Do not allow mounts if we do not have enough memory to preserve
* the minimum reserved pages. */ * the minimum reserved pages. */
if (tmpfs_mem_avail() < TMPFS_PAGES_MINRESERVED) if (tmpfs_mem_avail() < TMPFS_PAGES_MINRESERVED)
return (ENOSPC); return (ENOSPC);
/* Get the maximum number of memory pages this file system is /* Get the maximum number of memory pages this file system is
* allowed to use, based on the maximum size the user passed in * allowed to use, based on the maximum size the user passed in
Show All 30 Linestmpfs_mount(struct mount *mp)
LIST_INIT(&tmp->tm_nodes_used); LIST_INIT(&tmp->tm_nodes_used);
tmp->tm_size_max = size_max; tmp->tm_size_max = size_max;
tmp->tm_pages_max = pages; tmp->tm_pages_max = pages;
tmp->tm_pages_used = 0; tmp->tm_pages_used = 0;
new_unrhdr64(&tmp->tm_ino_unr, 2); new_unrhdr64(&tmp->tm_ino_unr, 2);
tmp->tm_ronly = (mp->mnt_flag & MNT_RDONLY) != 0; tmp->tm_ronly = (mp->mnt_flag & MNT_RDONLY) != 0;
tmp->tm_nonc = nonc; tmp->tm_nonc = nonc;
tmp->tm_nomtime = nomtime;
/* Allocate the root node. */ /* Allocate the root node. */
error = tmpfs_alloc_node(mp, tmp, VDIR, root_uid, root_gid, error = tmpfs_alloc_node(mp, tmp, VDIR, root_uid, root_gid,
root_mode & ALLPERMS, NULL, NULL, VNOVAL, &root); root_mode & ALLPERMS, NULL, NULL, VNOVAL, &root);
if (error != 0 || root == NULL) { if (error != 0 || root == NULL) {
free(tmp, M_TMPFSMNT); free(tmp, M_TMPFSMNT);
return (error); return (error);
▲ Show 20 Lines • Show All 230 Lines • Show Last 20 Lines