Page MenuHomeFreeBSD
Differential D23978

Use COUNTER_U64_SYSINIT() in a few places where it simplifies things.
ClosedPublic
Actions

Authored by markj on Mar 5 2020, 7:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 18, 5:42 PM
Unknown Object (File)
Sun, Sep 28, 5:19 PM
Unknown Object (File)
Sep 21 2025, 5:12 AM
Unknown Object (File)
Sep 13 2025, 6:48 AM
Unknown Object (File)
Sep 13 2025, 6:01 AM
Unknown Object (File)
Sep 13 2025, 5:08 AM
Unknown Object (File)
Sep 13 2025, 3:10 AM
Unknown Object (File)
Sep 13 2025, 12:29 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
Commits
rS358716: Use COUNTER_U64_DEFINE_EARLY() in places where it simplifies things.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29828
Build 27654: arc lint + arc unit

Event Timeline

markj created this revision.Mar 5 2020, 7:11 PM
Harbormaster completed remote builds in B29815: Diff 69235.Mar 5 2020, 7:11 PM
markj added a reviewer: kib.Mar 5 2020, 7:12 PM
kib added inline comments.Mar 5 2020, 9:28 PM
sys/vm/vm_object.c
167

This sequence of declaration/EARLY_COUNTER initialization and SYSINIT repeats very often in your patch. Would it make sense to add e.g. COUNTER_U64_SYSINIT_EARLY that would do everything?

markj added inline comments.Mar 5 2020, 9:34 PM
sys/vm/vm_object.c
167

That makes sense. Maybe COUNTER_U64_DEFINE_EARLY?

kib added inline comments.Mar 5 2020, 9:41 PM
sys/vm/vm_object.c
167

Sure.

markj updated this revision to Diff 69268.Mar 6 2020, 3:54 PM

Use COUNTER_U64_DEFINE_EARLY.

Harbormaster completed remote builds in B29828: Diff 69268.Mar 6 2020, 3:54 PM
kib accepted this revision.Mar 6 2020, 4:22 PM
This revision is now accepted and ready to land.Mar 6 2020, 4:22 PM
Closed by commit rS358716: Use COUNTER_U64_DEFINE_EARLY() in places where it simplifies things. (authored by markj). · Explain WhyMar 6 2020, 7:10 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rS358716: Use COUNTER_U64_DEFINE_EARLY() in places where it simplifies things..
Herald added a subscriber: imp. · View Herald TranscriptMar 6 2020, 7:10 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
22 lines
29 lines
vm/
13 lines
16 lines
16 lines
21 lines

Diff 69268

View Options

sys/kern/subr_smr.c

Loading...
View Options

sys/kern/vfs_cache.c

Loading...
View Options

sys/vm/swap_pager.c

Loading...
View Options

sys/vm/vm_object.c

Loading...
View Options

sys/vm/vm_page.c

Loading...
View Options

sys/vm/vm_reserv.c

Loading...