Page MenuHomeFreeBSD

Use COUNTER_U64_SYSINIT() in a few places where it simplifies things.
ClosedPublic

Authored by markj on Mar 5 2020, 7:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 4, 12:49 PM
Unknown Object (File)
Fri, Feb 28, 3:43 PM
Unknown Object (File)
Mon, Feb 24, 7:49 AM
Unknown Object (File)
Thu, Feb 20, 4:04 PM
Unknown Object (File)
Thu, Feb 20, 3:41 PM
Unknown Object (File)
Tue, Feb 18, 8:26 AM
Unknown Object (File)
Jan 11 2025, 12:08 AM
Unknown Object (File)
Jan 9 2025, 8:29 AM
Subscribers

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 29828
Build 27654: arc lint + arc unit

Event Timeline

sys/vm/vm_object.c
167

This sequence of declaration/EARLY_COUNTER initialization and SYSINIT repeats very often in your patch. Would it make sense to add e.g. COUNTER_U64_SYSINIT_EARLY that would do everything?

sys/vm/vm_object.c
167

That makes sense. Maybe COUNTER_U64_DEFINE_EARLY?

sys/vm/vm_object.c
167

Sure.

Use COUNTER_U64_DEFINE_EARLY.

This revision is now accepted and ready to land.Mar 6 2020, 4:22 PM