Differential D23618

Replace @rmtry with a lua version
ClosedPublic
Actions

Authored by bapt on Feb 11 2020, 10:41 AM.

Details

Reviewers

mat

Group Reviewers

portmgr

Commits

rP533339: Replace @rmtry shell implementation with a lua implementation

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 29288
Build 27198: arc lint + arc unit

Event Timeline

bapt created this revision.Feb 11 2020, 10:41 AM

Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptFeb 11 2020, 10:41 AM

Herald added a subscriber: mat. · View Herald Transcript

Harbormaster completed remote builds in B29288: Diff 68109.Feb 11 2020, 10:41 AM

Is there a docuentation of the pkg API for LUA ?

see the pkg-lua-script(5) provided with pkg 1.13

From pkg-lua-script(5):

The following function has been added:
 
out pkg.prefixed_path(in)
        prepend pkg_prefix to in if needed and returns it as out.

So, the doc says pkg.prefixed_path has one argument, and you are using two here.

prefixed_path only take one argument

Harbormaster completed remote builds in B29670: Diff 68941.Feb 28 2020, 3:48 PM

mat accepted this revision.Apr 29 2020, 2:04 PM

This revision is now accepted and ready to land.Apr 29 2020, 2:04 PM

Closed by commit rP533339: Replace @rmtry shell implementation with a lua implementation (authored by bapt). · Explain WhyApr 29 2020, 2:34 PM

This revision was automatically updated to reflect the committed changes.

bapt added a commit: rP533339: Replace @rmtry shell implementation with a lua implementation.

Revision Contents
Changeset List

Path

Size

Keywords/

rmtry.ucl

10 lines

Diff 68109

View Options

Replace @rmtry with a lua versionClosedPublicActions