tests: fusefs: silence remaining unsigned/signed comparison warnings
ClosedPublic
Actions

Authored by kevans on Jan 10 2020, 9:13 PM.

Details

Reviewers

asomers

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Commits

rS356614: tests: fusefs: silence remaining unsigned/signed comparison warnings

Summary

External GCC turns these into errors; cast to long to silence them.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 28594

Event Timeline

kevans created this revision.Jan 10 2020, 9:13 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 10 2020, 9:13 PM

Harbormaster completed remote builds in B28593: Diff 66601.Jan 10 2020, 9:13 PM

timespec.tv_nsec is defined as long, not time_t. So you should be casting to long.

This revision now requires changes to proceed.Jan 10 2020, 9:19 PM

Whoops, fix types.

Harbormaster completed remote builds in B28594: Diff 66603.Jan 10 2020, 9:23 PM

asomers accepted this revision.Jan 10 2020, 9:28 PM

This revision is now accepted and ready to land.Jan 10 2020, 9:28 PM

Closed by commit rS356614: tests: fusefs: silence remaining unsigned/signed comparison warnings (authored by kevans). · Explain WhyJan 10 2020, 9:51 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rS356614: tests: fusefs: silence remaining unsigned/signed comparison warnings.

Owners added a reviewer: Restricted Owners Package.Jan 10 2020, 9:51 PM

Revision Contents
Changeset List

Path

Size

tests/

sys/

fs/

fusefs/

setattr.cc

6 lines

Diff 66603

View Options

tests/sys/fs/fusefs/setattr.cc

tests: fusefs: silence remaining unsigned/signed comparison warningsClosedPublicActions