Differential D23037

vfs: eliminate v_tag from struct vnode
ClosedPublic
Actions

Authored by mjg on Jan 5 2020, 4:58 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 22, 6:47 AM

	Unknown Object (File)
	Tue, Sep 22, 6:15 AM

	Unknown Object (File)
	Tue, Sep 22, 6:09 AM

	Unknown Object (File)
	Mon, Sep 21, 4:36 AM

	Unknown Object (File)
	Sat, Sep 19, 8:40 AM

	Unknown Object (File)
	Fri, Sep 18, 3:31 PM

	Unknown Object (File)
	Tue, Sep 15, 11:36 PM

	Unknown Object (File)
	Thu, Sep 10, 4:22 AM

Subscribers

Details

Reviewers

kib
jeff

Commits

rS356432: vfs: eliminate v_tag from struct vnode

Summary

The only consumer uses it in a bogus manner, replace the use with an equivalent bogosity which does not require the field.

This also means getnewvnode takes the argument unnecessarily. I'll make a sweep to remove it later.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mjg created this revision.Jan 5 2020, 4:58 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 5 2020, 4:58 AM

Harbormaster completed remote builds in B28488: Diff 66368.Jan 5 2020, 4:58 AM

mjg edited the summary of this revision. (Show Details)Jan 5 2020, 5:01 AM

jeff accepted this revision.Jan 6 2020, 8:17 PM

This revision is now accepted and ready to land.Jan 6 2020, 8:17 PM

Closed by commit rS356432: vfs: eliminate v_tag from struct vnode (authored by mjg). · Explain WhyJan 7 2020, 4:29 AM

This revision was automatically updated to reflect the committed changes.

mjg added a commit: rS356432: vfs: eliminate v_tag from struct vnode.

kib added inline comments.Jan 7 2020, 1:18 PM

head/sys/security/mac_veriexec/mac_veriexec.c
754	What you can do is (struct vnode *)(vp->v_object->handle) for object != NULL && object->type == OBJT_VNODE. The only case that would be not handled by this expression is nullfs mount over tmpfs.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

6 lines

security/

mac_veriexec/

31 lines

sys/

1 line

Diff 66431

head/sys/kern/vfs_subr.c

Loading...

head/sys/security/mac_veriexec/mac_veriexec.c

Loading...

head/sys/sys/vnode.h

Loading...