go.mk: Avoid pollution of Go module cache with modules downloaded by gomod-vendor
ClosedPublic
Actions

Authored by dmgk on Jan 6 2020, 11:54 PM.

Details

Reviewers

swills
tobik

Group Reviewers

O5: Ports Framework	(Owns No Changed Paths)
portmgr

Commits

rP527631: Mk/Uses/go.mk: Avoid pollution of Go module cache with modules downloaded by…

Summary

Use module cache local to the WRKDIR and add the -modcacherw flag (available
in go1.14 [1, 2]) to instruct go mod vendor to leave directories
in the module cache read-write instead of making them unwritable.

[1] https://github.com/golang/go/issues/31481
[2] https://go-review.googlesource.com/c/go/+/202079/

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 28514
Build 26569: arc lint + arc unit

Event Timeline

dmgk created this revision.Jan 6 2020, 11:54 PM

Owners added a reviewer: O5: Ports Framework.Jan 6 2020, 11:54 PM

Herald added a reviewer: portmgr. · View Herald TranscriptJan 6 2020, 11:54 PM

Herald added a subscriber: mat. · View Herald Transcript

Harbormaster completed remote builds in B28514: Diff 66429.Jan 6 2020, 11:54 PM

dmgk retitled this revision from Mk/Uses/go.mk: Avoid polluting Go module cache with modules downloaded by gomod-vendor to Mk/Uses/go.mk: Avoid pollution of Go module cache with modules downloaded by gomod-vendor.Jan 6 2020, 11:59 PM

Awesome, looks great, thanks!

This revision is now accepted and ready to land.Jan 9 2020, 1:10 PM

dmgk mentioned this in D23151: lang/go: switch to the new bootstrap, add aarch64 support.Feb 28 2020, 1:34 PM

Closed by commit rP527631: Mk/Uses/go.mk: Avoid pollution of Go module cache with modules downloaded by… (authored by dmgk). · Explain WhyMar 2 2020, 1:58 PM

This revision was automatically updated to reflect the committed changes.

dmgk added a commit: rP527631: Mk/Uses/go.mk: Avoid pollution of Go module cache with modules downloaded by….