Differential D23046

Fix zone and keg alignment as well as boot pages calculations on numa.
ClosedPublic
Actions

Authored by jeff on Jan 5 2020, 11:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 16, 6:42 PM

	Unknown Object (File)
	Wed, Dec 3, 7:47 PM

	Unknown Object (File)
	Thu, Nov 27, 6:59 PM

	Unknown Object (File)
	Tue, Nov 25, 4:58 AM

	Unknown Object (File)
	Mon, Nov 24, 9:43 PM

	Unknown Object (File)
	Nov 14 2025, 11:46 PM

	Unknown Object (File)
	Nov 14 2025, 11:38 PM

	Unknown Object (File)
	Nov 14 2025, 9:48 PM

Subscribers

Details

Reviewers

rlibby
markj

Commits

rS356393: Fix uma boot pages calculations on NUMA machines that also don't have

Summary

While making NUMA amd64 w/o MD_SMALL_ALLOC boot I noticed a number of numa bugs but also weaker than required alignment. In practice the alignment of zones was actually dictated by the alignment of the per-cpu cache structure. This just clarifies existing behavior while simplifying code.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jeff created this revision.Jan 5 2020, 11:53 PM

Harbormaster completed remote builds in B28494: Diff 66394.Jan 5 2020, 11:54 PM

jeff edited the summary of this revision. (Show Details)Jan 5 2020, 11:55 PM

jeff added reviewers: rlibby, markj.

jeff set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptJan 5 2020, 11:55 PM

jeff added inline comments.Jan 5 2020, 11:56 PM

sys/amd64/include/vmparam.h
79 ↗	(On Diff #66394)	obviously not committing this.

rlibby accepted this revision.Jan 6 2020, 12:10 AM

This revision is now accepted and ready to land.Jan 6 2020, 12:10 AM

markj accepted this revision.Jan 6 2020, 1:03 AM

markj added inline comments.

sys/vm/uma_int.h
169 ↗	(On Diff #66394)	Typo: terminology. I think we used to define CACHE_LINE_SIZE to 128 on amd64 for this reason. I'm not sure when that changed.

Closed by commit rS356393: Fix uma boot pages calculations on NUMA machines that also don't have (authored by jeff). · Explain WhyJan 6 2020, 2:51 AM

This revision was automatically updated to reflect the committed changes.

jeff added a commit: rS356393: Fix uma boot pages calculations on NUMA machines that also don't have.

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

70 lines

11 lines

13 lines

Diff 66398

head/sys/vm/uma_core.c

Loading...

head/sys/vm/uma_int.h

Loading...

head/sys/vm/vm_page.c

Loading...