Page MenuHomeFreeBSD
Differential D22871

Battery capacity remaining percent in top(1)
ClosedPublic
Actions

Authored by antranigv_freebsd.am on Dec 19 2019, 12:09 AM.
Tags
None
Referenced Files
F103471053: D22871.diff
Mon, Nov 25, 11:15 AM
F103460138: D22871.id65887.diff
Mon, Nov 25, 7:51 AM
F103439349: D22871.id65799.diff
Mon, Nov 25, 1:23 AM
F103431884: D22871.diff
Sun, Nov 24, 11:04 PM
Unknown Object (File)
Sun, Nov 24, 8:45 AM
Unknown Object (File)
Sun, Nov 24, 7:35 AM
Unknown Object (File)
Sun, Nov 24, 3:00 AM
Unknown Object (File)
Sat, Nov 23, 10:36 PM
View All Files
Subscribers
afedorov
imp
philip
Contributor Reviews (src)

Details

Reviewers
philip
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Commits
rS355978: top: display battery capacity remaining

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 28257
Build 26375: arc lint + arc unit

Event Timeline

antranigv_freebsd.am created this revision.Dec 19 2019, 12:09 AM
Owners added a reviewer: Restricted Owners Package.Dec 19 2019, 12:09 AM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptDec 19 2019, 12:09 AM
Harbormaster completed remote builds in B28223: Diff 65799.Dec 19 2019, 12:09 AM
afedorov added a subscriber: afedorov.Dec 19 2019, 7:00 AM
philip requested changes to this revision.Dec 19 2019, 8:41 AM
philip added a subscriber: philip.

Except for some very minor style issues, this looks like a good change! Thanks for the submission.

usr.bin/top/display.c
1328

Follow the style of the rest of the file please.

usr.bin/top/display.h
28

This should be in alphabetical order like the other variables (style).

This revision now requires changes to proceed.Dec 19 2019, 8:41 AM
antranigv_freebsd.am updated this revision to Diff 65851.Dec 20 2019, 3:20 PM

Trying to comply to style(9)

Harbormaster completed remote builds in B28256: Diff 65851.Dec 20 2019, 3:20 PM
antranigv_freebsd.am updated this revision to Diff 65853.Dec 20 2019, 4:12 PM
antranigv_freebsd.am marked an inline comment as done.

Update display.c to follow style guidelines.

Harbormaster completed remote builds in B28257: Diff 65853.Dec 20 2019, 4:12 PM
imp added a comment.Dec 20 2019, 5:41 PM

This looks generally good, one minor comment and I think it's ready to go.

usr.bin/top/machine.c
384

It would be nice to have a quick comment here saying that only batteries reported via ACPI are counted. Anybody still running APM won't have these numbers, but that's totally fine: APM is likely to be deleted soon anyway as laptops that require you use APM aren't really viable anymore as laptops... I'm also unsure how the 'pinebook' reports this information, but that too is a niche thing that's kinda weird still.... So just a quick comment will suffice.

antranigv_freebsd.am added a comment.Dec 20 2019, 6:39 PM
  1. I know someone in the city who has a Pinebook, should I try running on it? 2) So now I should just set a comment that says this is ACPI only? 😄
usr.bin/top/machine.c
384

Should I try running this on a Pinebook? I know someone in the city who has one.

imp added a comment.Dec 20 2019, 9:29 PM
In D22871#501182, @antranigv_freebsd.am wrote:
  1. I know someone in the city who has a Pinebook, should I try running on it? 2) So now I should just set a comment that says this is ACPI only? 😄

1: sure, why not. I wouldn't hold this up for that testing, it's more of a good to know read.
2: Yup.

antranigv_freebsd.am updated this revision to Diff 65876.Dec 20 2019, 10:13 PM

Note in the comments that only ACPI reported batteries are supported

Harbormaster completed remote builds in B28272: Diff 65876.Dec 20 2019, 10:13 PM
philip accepted this revision.Dec 21 2019, 3:28 AM

This looks good now. I'll commit it.

This revision is now accepted and ready to land.Dec 21 2019, 3:28 AM
Closed by commit rS355978: top: display battery capacity remaining (authored by philip). · Explain WhyDec 21 2019, 5:03 AM
This revision was automatically updated to reflect the committed changes.
philip added a commit: rS355978: top: display battery capacity remaining.

Revision Contents
Changeset List

PathSize
usr.bin/
top/
1 line
9 lines
2 lines
16 lines
3 lines

Diff 65853

View Options

usr.bin/top/display.h

Loading...
View Options

usr.bin/top/display.c

Loading...
View Options

usr.bin/top/machine.h

Loading...
View Options

usr.bin/top/machine.c

Loading...
View Options

usr.bin/top/top.c

Loading...