Page MenuHomeFreeBSD
Differential D2958

Improve support for <buildtarget> in the DTD
ClosedPublic
Actions

Authored by wblock on Jun 30 2015, 2:33 PM.
Tags
Referenced Files
Unknown Object (File)
Thu, Nov 27, 9:06 PM
Unknown Object (File)
Mon, Nov 24, 4:44 AM
Unknown Object (File)
Sat, Nov 22, 1:03 PM
Unknown Object (File)
Fri, Nov 21, 8:56 PM
Unknown Object (File)
Fri, Nov 21, 2:25 AM
Unknown Object (File)
Sun, Nov 16, 5:49 AM
Unknown Object (File)
Sat, Nov 15, 1:33 PM
Unknown Object (File)
Oct 23 2025, 1:19 AM
View All Files
Subscribers
hrs

Details

Reviewers
hrs
Group Reviewers
doceng
Commits
rD46931: Improve support for <buildtarget> in the DTD. Allow common attributes
Summary

Add support for "lang" attribute to the buildtarget element to support XML translations.
Add buildtarget element to the list of children allowed in <title>. This is particularly important for the Porter's Handbook.

The "lang" attribute was included with https://reviews.freebsd.org/D2947, but will cause no harm on its own and makes our XML more standard.

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

wblock updated this revision to Diff 6585.Jun 30 2015, 2:33 PM
wblock retitled this revision from to Improve support for <buildtarget> in the DTD.
wblock updated this object.
wblock edited the test plan for this revision. (Show Details)
wblock added a reviewer: doceng.
wblock set the repository for this revision to rD FreeBSD doc repository - subversion.
wblock added a project: doceng.
mat mentioned this in D2959: Allow buildtarget inside title, and add lang to it..Jul 2 2015, 2:40 PM
hrs added a subscriber: hrs.Jul 6 2015, 6:06 PM
hrs added inline comments.
share/xml/docbook50.dtd
24

Please use %db.common.attributes; for buildtarget instead of picking up xml:lang only.

wblock updated this revision to Diff 6735.Jul 6 2015, 7:33 PM

Use %db.common.attributes; in buildtarget, and move buildtarget later in the file so db.common.attributes has been defined when it is referenced in buildtarget.

wblock marked an inline comment as done.Jul 6 2015, 7:35 PM
hrs accepted this revision.Jul 6 2015, 7:59 PM
hrs added a reviewer: hrs.

I think it is ready to commit.

This revision is now accepted and ready to land.Jul 6 2015, 7:59 PM
Closed by commit rD46931: Improve support for <buildtarget> in the DTD. Allow common attributes (authored by wblock). · Explain WhyJul 6 2015, 8:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
share/
xml/
6 lines

Diff 6585

View Options

share/xml/docbook50.dtd

Loading...