Fix a couple of minor issues with newfs_msdos
ClosedPublic
Actions

Authored by delphij on Dec 8 2019, 1:06 AM.

Tags

None

Referenced Files

	F146241892: D22729.id.diff
	Sun, Mar 1, 1:33 AM

	Unknown Object (File)
	Sat, Feb 21, 9:35 PM

	Unknown Object (File)
	Fri, Feb 20, 7:26 PM

	Unknown Object (File)
	Sun, Feb 8, 10:11 AM

	Unknown Object (File)
	Sun, Feb 8, 8:26 AM

	Unknown Object (File)
	Sat, Jan 31, 2:23 AM

	Unknown Object (File)
	Jan 16 2026, 12:43 AM

	Unknown Object (File)
	Dec 13 2025, 7:38 PM

View All Files

Subscribers

imp

Details

Reviewers

emaste
imp

Commits

rS355513: Fix a couple of minor issues with newfs_msdos:

Summary

Do not unnecessarily strdup().
Check return value of getdiskinfo(), if it failed, bail out.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 28033
Build 26184: arc lint + arc unit

Event Timeline

delphij created this revision.Dec 8 2019, 1:06 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 8 2019, 1:06 AM

Harbormaster completed remote builds in B28033: Diff 65384.Dec 8 2019, 1:06 AM

imp accepted this revision.Dec 8 2019, 1:15 AM

This revision is now accepted and ready to land.Dec 8 2019, 1:15 AM

Closed by commit rS355513: Fix a couple of minor issues with newfs_msdos: (authored by delphij). · Explain WhyDec 8 2019, 1:20 AM

This revision was automatically updated to reflect the committed changes.

delphij added a commit: rS355513: Fix a couple of minor issues with newfs_msdos:.

Revision Contents
Changeset List

Path

Size

sbin/

newfs_msdos/

mkfs_msdos.c

8 lines

newfs_msdos.c

3 lines

Diff 65384

View Options

sbin/newfs_msdos/mkfs_msdos.c