First draft of new ghostscript.mk USES. Only included the bare minimum to
not spam this review with all the USE_GHOSTSCRIPT changes. Would like
feedback on the ghostscript.mk content before proceeding with converting
the ports tree, and submitting that for exp-run.
Details
Details
- Reviewers
bapt - Group Reviewers
portmgr - Commits
- rP392322: Convert code in bsd.port.mk for USE_GHOSTSCRIPT* to USES=ghostscript.
tested with print/libspecter with different arguments.
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
At first glance it looks good, but that means all the ports using USE_GHOSTSCRIPT should also be converted and a course this will have to go though a couple of exp-runs :)
Comment Actions
Update
Unbump libspecter no revision bump needed.
Add bsd.sanity.mk lines about USE_GHOSTSCRIPT
Add check to check if GHOSTSCRIPT_DEFAULT is a valid value
bsd.port.mk already does _ARGS:S/,/ / so we don't have to.
| Mk/Uses/ghostscript.mk | ||
|---|---|---|
| 60 | maybe add the invalid value in the IGNORE message, like ... value: ${GHOSTSCRIPT_DEFAULT}, please ... | |
Comment Actions
Small update
Report the actualy incorrect GHOSTSCRIPT_DEFAULT value in the error message
Add CHANGES again.
Comment Actions
Add antoine@'s suggestion add back WITHOUT_X11 processing.
I tried to write some code to check if OPTIONS_DEFINE=X11 was set and
honoring PORT_OPTIONS:MX11 but I couldn't get that working.
Either we leave it like this or I'm open for suggestions on how to impliment
that.