Pass 0 to __builtin_frame_address() to appease modern GCC.
ClosedPublic
Actions

Authored by jhb on Nov 28 2019, 8:35 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 8, 7:27 PM

	Unknown Object (File)
	Tue, Sep 8, 7:24 PM

	Unknown Object (File)
	Tue, Sep 8, 7:21 PM

	Unknown Object (File)
	Fri, Sep 4, 8:25 AM

	Unknown Object (File)
	Fri, Aug 21, 8:36 PM

	Unknown Object (File)
	Thu, Aug 20, 7:07 AM

	Unknown Object (File)
	Aug 10 2026, 7:50 PM

	Unknown Object (File)
	Aug 10 2026, 7:49 PM

View All Files

Subscribers

imp

Details

Reviewers

marius
imp

Commits

rS355374: Pass 0 to __builtin_frame_address() to appease modern GCC.

Summary

Modern versions of GCC warn about passing non-zero values to
__builtin_frame_address(). Passing 1 is a cosmetic change to
remove the db_trace_self() frame from the printed stack trace.

Test Plan

lets sparc64 GENERIC build with GCC 6.x.
compile tested only, not run tested

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 27843
Build 26020: arc lint + arc unit

Event Timeline

jhb created this revision.Nov 28 2019, 8:35 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 28 2019, 8:35 PM

Harbormaster completed remote builds in B27843: Diff 65024.Nov 28 2019, 8:35 PM

imp accepted this revision.Nov 28 2019, 8:44 PM

This revision is now accepted and ready to land.Nov 28 2019, 8:44 PM

looks good to me

Closed by commit rS355374: Pass 0 to __builtin_frame_address() to appease modern GCC. (authored by jhb). · Explain WhyDec 3 2019, 11:20 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rS355374: Pass 0 to __builtin_frame_address() to appease modern GCC..

Revision Contents
Changeset List

Path

Size

sys/

sparc64/

db_trace.c

2 lines

Diff 65024

View Options

sys/sparc64/sparc64/db_trace.c

Pass 0 to __builtin_frame_address() to appease modern GCC.ClosedPublicActions