Paths

Table of Contentst

Differential D22557

Add ESP dummy frames support
ClosedPublic
Actions

Authored by aurelien.cazuc.external_stormshield.eu on Nov 26 2019, 9:45 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Feb 8 2024, 9:24 PM

	Unknown Object (File)
	Jan 17 2024, 6:54 PM

	Unknown Object (File)
	Jan 11 2024, 10:01 PM

	Unknown Object (File)
	Dec 26 2023, 5:13 AM

	Unknown Object (File)
	Dec 23 2023, 5:51 PM

	Unknown Object (File)
	Dec 23 2023, 1:04 AM

	Unknown Object (File)
	Dec 20 2023, 8:15 PM

	Unknown Object (File)
	Dec 19 2023, 7:15 AM

View All 33 Files

Subscribers

Details

Reviewers

Commits

rS355129: Add support for dummy ESP packets with next header field equal to

Summary

This patch provides support of dummy frames as specified by RFC 4303
Packets with IPPROTO_NONE are silently dropped just before ipsecX_common_input_cb

Test Plan

In manual testing, when generating packets with IPPROTO_NONE as next_header, packets are correctly dropped

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

aurelien.cazuc.external_stormshield.eu created this revision.Nov 26 2019, 9:45 AM

Herald added a subscriber: ae. · View Herald TranscriptNov 26 2019, 9:45 AM

ae added inline comments.Nov 26 2019, 3:51 PM

sys/netipsec/xform_esp.c
629	This indentation does not conform to style(9). I think you can just use if (lastthree[2] == IPPROTO_NONE) goto bad; the `error` variable should already be zero.

Remarks from ae

ae accepted this revision.Nov 27 2019, 12:45 AM

This revision is now accepted and ready to land.Nov 27 2019, 12:45 AM

Hi @ae ,

Would you prefer commit it yourself or let fabient commit it ?
If you commit it yourself, please mention Stormshield as sponsor.

Thanks

Closed by commit rS355129: Add support for dummy ESP packets with next header field equal to (authored by ae). · Explain WhyNov 27 2019, 10:24 AM

This revision was automatically updated to reflect the committed changes.

ae added a commit: rS355129: Add support for dummy ESP packets with next header field equal to.

Herald added a subscriber: imp. · View Herald TranscriptNov 27 2019, 10:24 AM

Revision Contents
Changeset List

Path

Size

sys/

netipsec/

4 lines

Diff 64889

sys/netipsec/xform_esp.c

Loading...