Page MenuHomeFreeBSD
Differential D22316

lang/go-devel: Add support for aarch64
ClosedPublic
Actions

Authored by dmgk on Nov 11 2019, 3:44 PM.
Tags
None
Referenced Files
F108227143: D22316.diff
Wed, Jan 22, 9:01 PM
Unknown Object (File)
Mon, Jan 13, 8:28 PM
Unknown Object (File)
Mon, Jan 13, 3:48 AM
Unknown Object (File)
Fri, Jan 3, 5:07 PM
Unknown Object (File)
Dec 21 2024, 3:55 AM
Unknown Object (File)
Dec 18 2024, 6:57 AM
Unknown Object (File)
Oct 20 2024, 9:08 AM
Unknown Object (File)
Oct 4 2024, 8:04 PM
View All Files
Subscribers
mat

Details

Reviewers
tobik
mikael
jlaffaye
Commits
rP517703: lang/go-devel: Add support for aarch64
Summary

AArch64 support was recently merged by the Go project and is slated to be in
go1.14. This patch adds freebsd/arm64 support to lang/go-devel first, the
intention is to similarly update lang/go when go1.14 is officially released.

The most notable change is migration to the new bootstrap [1] because aarch64
is not supported by go1.4.

[1] https://github.com/dmgk/go-bootstrap

Test Plan

Tested on amd64, i386 and aarch64 (12.1-STABLE eef4ba7(master) GENERIC arm64
on RPI3)

Ports can be tested on real hardware by setting GO_PORT=lang/go-devel (building under qemu-user is currently not possible due to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240037).

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 27532
Build 25756: arc lint + arc unit

Event Timeline

dmgk created this revision.Nov 11 2019, 3:44 PM
Herald added a subscriber: mat. · View Herald TranscriptNov 11 2019, 3:44 PM
Harbormaster completed remote builds in B27448: Diff 64182.Nov 11 2019, 3:44 PM
dmgk edited the test plan for this revision. (Show Details)Nov 11 2019, 3:51 PM
dmgk added a reviewer: jlaffaye.
mikael added inline comments.Nov 11 2019, 4:03 PM
lang/go-devel/Makefile
39

leading space?

88

leading space?

90

same here

dmgk updated this revision to Diff 64184.Nov 11 2019, 4:17 PM

Remove leading spaces.

Harbormaster completed remote builds in B27450: Diff 64184.Nov 11 2019, 4:17 PM
dmgk updated this revision to Diff 64203.Nov 11 2019, 8:43 PM

Add dependency on devel/binutils on aarch64 - Go needs ld.bfd for working cgo.

Harbormaster completed remote builds in B27455: Diff 64203.Nov 11 2019, 8:43 PM
tobik added a comment.Nov 14 2019, 7:33 AM
In D22316#488073, @dmgk wrote:

Add dependency on devel/binutils on aarch64 - Go needs ld.bfd for working cgo.

Why? Is this also the case on other archs? If it is needed to get a functional toolchain should it be optional?

mikael added a comment.Nov 14 2019, 8:07 AM

! In D22316#488910, @tobik wrote:
Why? Is this also the case on other archs? If it is needed to get a functional toolchain should it be optional?

Yes there are bugs in lld8 and lld9, the test suite fails with cgo enabled. These bugs are fixed in lld10 (devel/llvm-devel) : https://github.com/golang/go/issues/35197
AFAICT it only affects aarch64

lang/go-devel/Makefile
50

I'm not sure adding only one option is useful, either put an hard dep on binutils or add llvm-devel as an option. I'd prefer an hard dep on binutils.

dmgk added a comment.EditedNov 14 2019, 11:45 AM
In D22316#488910, @tobik wrote:
In D22316#488073, @dmgk wrote:

Add dependency on devel/binutils on aarch64 - Go needs ld.bfd for working cgo.

Why? Is this also the case on other archs? If it is needed to get a functional toolchain should it be optional?

No, it is needed only on aarch64 and only for cgo. Other archs are OK with base lld as far as I know.

The rationale behind making it an option is that GNU ld is needed only for cgo which itself is not required for most Go programs,
so if someone wants to keep their arm64 env lean, well, there's option for that.

tobik added a comment.Nov 15 2019, 12:29 PM
In D22316#488921, @mikael.urankar_gmail.com wrote:

Yes there are bugs in lld8 and lld9, the test suite fails with cgo enabled. These bugs are fixed in lld10 (devel/llvm-devel) : https://github.com/golang/go/issues/35197
AFAICT it only affects aarch64

Ok.

In D22316#488932, @dmgk wrote:

The rationale behind making it an option is that GNU ld is needed only for cgo which itself is not required for most Go programs,
so if someone wants to keep their arm64 env lean, well, there's option for that.

Fair enough.

Ports can be tested on real hardware by setting GO_PORT=lang/go-devel

When will Go 1.14 come out? Can we unlock binary packages for Go ports on aarch64 in the mean time with something like

GO_PORT_aarch64=	lang/go-devel
GO_PORT?=	${GO_PORT_${ARCH}:Ulang/go}

in Mk/Uses/go.mk?

(building under qemu-user is currently not possible due to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240037).

In that case go-devel probably needs the QEMU_EMULATING IGNORE too like lang/go.

lang/go-devel/Makefile
67

${ECHO_CMD}

dmgk updated this revision to Diff 64367.Nov 15 2019, 1:28 PM
  • Lets keep it simple, remove BFD knob and add hard RUN/TEST dep on devel/binutils on aarch64
  • Disable building under qemu-user
  • Add missing GOARM variable
  • Update to the current master
Harbormaster completed remote builds in B27532: Diff 64367.Nov 15 2019, 1:28 PM
dmgk marked 4 inline comments as done.Nov 15 2019, 1:28 PM
mikael accepted this revision.Nov 15 2019, 1:47 PM
This revision is now accepted and ready to land.Nov 15 2019, 1:47 PM
tobik added inline comments.Nov 15 2019, 1:50 PM
lang/go-devel/Makefile
26–29
RUN_DEPENDS_aarch64=	binutils>0:devel/binutils
TEST_DEPENDS_aarch64=	binutils>0:devel/binutils

AFAICT devel/binutils does not install a binutils binary.

dmgk updated this revision to Diff 64368.Nov 15 2019, 1:57 PM

Fix DEPENDS.

This revision now requires review to proceed.Nov 15 2019, 1:57 PM
Harbormaster completed remote builds in B27533: Diff 64368.Nov 15 2019, 1:57 PM
tobik accepted this revision.Nov 15 2019, 1:58 PM
This revision is now accepted and ready to land.Nov 15 2019, 1:58 PM
dmgk marked an inline comment as done.Nov 15 2019, 1:58 PM
dmgk added inline comments.
lang/go-devel/Makefile
26–29

Ah yes, thanks for catching.

dmgk marked an inline comment as done.Nov 15 2019, 2:01 PM
In D22316#489360, @tobik wrote:

When will Go 1.14 come out? Can we unlock binary packages for Go ports on aarch64 in the mean time with something like

GO_PORT_aarch64=	lang/go-devel
GO_PORT?=	${GO_PORT_${ARCH}:Ulang/go}

in Mk/Uses/go.mk?

Good idea, will submit a review shortly.

Closed by commit rP517703: lang/go-devel: Add support for aarch64 (authored by dmgk). · Explain WhyNov 15 2019, 10:45 PM
This revision was automatically updated to reflect the committed changes.
dmgk added a commit: rP517703: lang/go-devel: Add support for aarch64.

Revision Contents
Changeset List

PathSize
lang/
go-devel/
108 lines
16 lines

Diff 64367

View Options

lang/go-devel/Makefile

Loading...
View Options

lang/go-devel/distinfo

Loading...