Page MenuHomeFreeBSD
Differential D22347

hide map entry next and prev fields
ClosedPublic
Actions

Authored by dougm on Nov 13 2019, 4:25 AM.
Tags
None
Referenced Files
F114858329: D22347.id64276.diff
Thu, Apr 17, 6:53 PM
Unknown Object (File)
Wed, Apr 16, 8:33 PM
Unknown Object (File)
Mon, Apr 14, 10:56 AM
Unknown Object (File)
Mon, Apr 14, 4:08 AM
Unknown Object (File)
Mon, Apr 14, 12:56 AM
Unknown Object (File)
Mon, Apr 14, 12:12 AM
Unknown Object (File)
Mar 2 2025, 1:41 AM
Unknown Object (File)
Jan 17 2025, 8:20 PM
View All 48 Files
Subscribers
imp

Details

Reviewers
markj
Commits
rS354684: Define wrapper functions vm_map_entry_{succ,pred} to act as wrappers
Summary

Define wrapper functions vm_map_entry_{succ,pred} to act as wrappers around entry->{next,prev} when those are used for ordered list traversal, and use those wrapper functions everywhere. Where the next field is used for maintaining a stack of deferred operations, #define defer_next to make that different usage clearer, and then use the 'right' pointer instead of 'next' for that purpose.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm created this revision.Nov 13 2019, 4:25 AM
markj accepted this revision.Nov 13 2019, 3:24 PM

Thanks. If you plan to commit this patch on its own, I'd suggest adding a comment above defer_next, even though that definition would be deleted shortly after.

This revision is now accepted and ready to land.Nov 13 2019, 3:24 PM
Closed by commit rS354684: Define wrapper functions vm_map_entry_{succ,pred} to act as wrappers (authored by dougm). · Explain WhyNov 13 2019, 3:56 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rS354684: Define wrapper functions vm_map_entry_{succ,pred} to act as wrappers.
Herald added a subscriber: imp. · View Herald TranscriptNov 13 2019, 3:56 PM

Revision Contents
Changeset List

PathSize
sys/
security/
mac/
3 lines
vm/
17 lines
130 lines
9 lines

Diff 64272

View Options

sys/security/mac/mac_process.c

Show First 20 Lines • Show All 138 Lines • ▼ Show 20 Lines
/* Linux 3.19: */ /* Linux 3.19: */
DUMMY(execveat); DUMMY(execveat);
/* Linux 4.2: */ /* Linux 4.2: */
DUMMY(userfaultfd); DUMMY(userfaultfd);
/* Linux 4.3: */ /* Linux 4.3: */
DUMMY(membarrier); DUMMY(membarrier);
/* Linux 4.4: */ /* Linux 4.4: */
DUMMY(mlock2); DUMMY(mlock2);
/* Linux 4.5: */
DUMMY(copy_file_range);
/* Linux 4.6: */ /* Linux 4.6: */
DUMMY(preadv2); DUMMY(preadv2);
DUMMY(pwritev2); DUMMY(pwritev2);
/* Linux 4.8: */ /* Linux 4.8: */
DUMMY(pkey_mprotect); DUMMY(pkey_mprotect);
DUMMY(pkey_alloc); DUMMY(pkey_alloc);
DUMMY(pkey_free); DUMMY(pkey_free);
/* Linux 4.11: */ /* Linux 4.11: */
▲ Show 20 Lines • Show All 51 Lines • Show Last 20 Lines
View Options

sys/vm/vm_map.h

Show First 20 Lines • Show All 138 Lines • ▼ Show 20 Lines
/* Linux 3.19: */ /* Linux 3.19: */
DUMMY(execveat); DUMMY(execveat);
/* Linux 4.2: */ /* Linux 4.2: */
DUMMY(userfaultfd); DUMMY(userfaultfd);
/* Linux 4.3: */ /* Linux 4.3: */
DUMMY(membarrier); DUMMY(membarrier);
/* Linux 4.4: */ /* Linux 4.4: */
DUMMY(mlock2); DUMMY(mlock2);
/* Linux 4.5: */
DUMMY(copy_file_range);
/* Linux 4.6: */ /* Linux 4.6: */
DUMMY(preadv2); DUMMY(preadv2);
DUMMY(pwritev2); DUMMY(pwritev2);
/* Linux 4.8: */ /* Linux 4.8: */
DUMMY(pkey_mprotect); DUMMY(pkey_mprotect);
DUMMY(pkey_alloc); DUMMY(pkey_alloc);
DUMMY(pkey_free); DUMMY(pkey_free);
/* Linux 4.11: */ /* Linux 4.11: */
▲ Show 20 Lines • Show All 51 Lines • Show Last 20 Lines
View Options

sys/vm/vm_map.c

Show First 20 Lines • Show All 138 Lines • ▼ Show 20 Lines
/* Linux 3.19: */ /* Linux 3.19: */
DUMMY(execveat); DUMMY(execveat);
/* Linux 4.2: */ /* Linux 4.2: */
DUMMY(userfaultfd); DUMMY(userfaultfd);
/* Linux 4.3: */ /* Linux 4.3: */
DUMMY(membarrier); DUMMY(membarrier);
/* Linux 4.4: */ /* Linux 4.4: */
DUMMY(mlock2); DUMMY(mlock2);
/* Linux 4.5: */
DUMMY(copy_file_range);
/* Linux 4.6: */ /* Linux 4.6: */
DUMMY(preadv2); DUMMY(preadv2);
DUMMY(pwritev2); DUMMY(pwritev2);
/* Linux 4.8: */ /* Linux 4.8: */
DUMMY(pkey_mprotect); DUMMY(pkey_mprotect);
DUMMY(pkey_alloc); DUMMY(pkey_alloc);
DUMMY(pkey_free); DUMMY(pkey_free);
/* Linux 4.11: */ /* Linux 4.11: */
▲ Show 20 Lines • Show All 51 Lines • Show Last 20 Lines
View Options

sys/vm/vm_mmap.c

Show First 20 Lines • Show All 138 Lines • ▼ Show 20 Lines
/* Linux 3.19: */ /* Linux 3.19: */
DUMMY(execveat); DUMMY(execveat);
/* Linux 4.2: */ /* Linux 4.2: */
DUMMY(userfaultfd); DUMMY(userfaultfd);
/* Linux 4.3: */ /* Linux 4.3: */
DUMMY(membarrier); DUMMY(membarrier);
/* Linux 4.4: */ /* Linux 4.4: */
DUMMY(mlock2); DUMMY(mlock2);
/* Linux 4.5: */
DUMMY(copy_file_range);
/* Linux 4.6: */ /* Linux 4.6: */
DUMMY(preadv2); DUMMY(preadv2);
DUMMY(pwritev2); DUMMY(pwritev2);
/* Linux 4.8: */ /* Linux 4.8: */
DUMMY(pkey_mprotect); DUMMY(pkey_mprotect);
DUMMY(pkey_alloc); DUMMY(pkey_alloc);
DUMMY(pkey_free); DUMMY(pkey_free);
/* Linux 4.11: */ /* Linux 4.11: */
▲ Show 20 Lines • Show All 51 Lines • Show Last 20 Lines