Differential D22185

Fix vmstat(8) output
ClosedPublic
Actions

Authored by trasz on Oct 29 2019, 10:49 PM.

Tags

None

Referenced Files

	F103243612: D22185.id63771.diff
	Fri, Nov 22, 1:58 PM

	F103235997: D22185.diff
	Fri, Nov 22, 12:21 PM

	Unknown Object (File)
	Thu, Nov 14, 9:18 AM

	Unknown Object (File)
	Sun, Nov 10, 7:53 AM

	Unknown Object (File)
	Sep 24 2024, 5:26 PM

	Unknown Object (File)
	Sep 24 2024, 5:26 PM

	Unknown Object (File)
	Sep 24 2024, 5:26 PM

	Unknown Object (File)
	Sep 23 2024, 2:42 PM

View All 50 Files

Subscribers

Details

Reviewers

Commits

rS354533: Humanize more columns in the vmstat(8) output and adjust widths.

Summary

Humanize more columns in the vmstat(8) output and adjust widths. The few that are not humanized are usually 0. This makes the output mostly aligned.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Oct 29 2019, 10:49 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 29 2019, 10:49 PM

Harbormaster completed remote builds in B27268: Diff 63771.Oct 29 2019, 10:49 PM

Fix layout for one disk setups.

Harbormaster completed remote builds in B27275: Diff 63791.Oct 30 2019, 12:36 PM

trasz edited the summary of this revision. (Show Details)Oct 30 2019, 2:06 PM

trasz added a reviewer: allanjude.

(Tinderboxed.)

allanjude added inline comments.Nov 1 2019, 10:17 PM

usr.bin/vmstat/vmstat.c
796 ↗	(On Diff #63791)	Don't we need the space here, between the two values?
845 ↗	(On Diff #63791)	Why did you decide not to humanize the # of interrupts?

trasz added inline comments.Nov 1 2019, 11:35 PM

usr.bin/vmstat/vmstat.c
796 ↗	(On Diff #63791)	No, prthuman() seems to insert whitespace by itself.
845 ↗	(On Diff #63791)	There's no room to extend it from 4 to 5 chars. Same with pi, po, and disk iops :-( I skipped those that seem mostly under four characters wide in (my) typical workloads.

Reviewed By: allanjude

This revision is now accepted and ready to land.Nov 7 2019, 4:53 PM

Closed by commit rS354533: Humanize more columns in the vmstat(8) output and adjust widths. (authored by trasz). · Explain WhyNov 8 2019, 11:10 AM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rS354533: Humanize more columns in the vmstat(8) output and adjust widths..

Revision Contents
Changeset List

Path

Size

head/

usr.bin/

vmstat/

80 lines

Diff 64067

head/usr.bin/vmstat/vmstat.c

Loading...