Page MenuHomeFreeBSD

powerpc/mpc85xx: Add MSI support for Freescale PowerPC SoCs
ClosedPublic

Authored by jhibbits on Oct 13 2019, 7:14 PM.
Tags
None
Referenced Files
F151844551: D22014.id63236.diff
Sat, Apr 11, 1:31 AM
Unknown Object (File)
Tue, Apr 7, 12:05 PM
Unknown Object (File)
Fri, Mar 27, 1:02 PM
Unknown Object (File)
Mon, Mar 23, 6:24 AM
Unknown Object (File)
Mon, Mar 23, 6:19 AM
Unknown Object (File)
Sun, Mar 22, 4:11 AM
Unknown Object (File)
Sat, Mar 21, 1:59 AM
Unknown Object (File)
Fri, Mar 20, 3:51 AM
Subscribers
None

Details

Reviewers
bdragon
nwhitehorn
jhibbits
Group Reviewers
PowerPC
Summary

Freescale SoCs use a set of IRQs at the high end of the OpenPIC IRQ
list, not counted in the NIRQs of the Feature reporting register. Some
SoCs include a MSI inbound window in the PCIe controller configuration
registers as well, but some don't. Currently, this only handles the
SoCs *with* the MSI window.

There are 256 MSIs per MSI bank (32 per MSI IRQ, 8 IRQs per MSI bank).
The P5020 has 3 banks, yielding up to 768 MSIs; older SoCs have only one
bank.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 27202
Build 25468: arc lint + arc unit

Event Timeline

sys/powerpc/mpc85xx/pci_mpc85xx.c
141

patch band conflicted due to rS353745

235–236

conflict w/ rS353745

265

already in rS353604

290

already in rS353604

316–317

will conflict with D22050.

334–338

conflict due to rS353745

sys/powerpc/powerpc/openpic.c
193

is the 256 here OPENPIC_IRQMAX or some other 256?

jhibbits added inline comments.
sys/powerpc/powerpc/openpic.c
193

Yes, it's OPENPIC_IRQMAX. The idea being that if there are hidden IRQs, just set the number of IRQs to the maximum possible number supported.

This revision is now accepted and ready to land.Nov 8 2019, 3:01 PM