Differential D21988

[PowerPC] [BookE] Fix read past end of struct
ClosedPublic
Actions

Authored by bdragon on Oct 12 2019, 1:13 AM.

Tags

Referenced Files

	F168033648: D21988.id.diff
	Wed, Aug 26, 1:12 AM

	F168028542: D21988.diff
	Wed, Aug 26, 12:31 AM

	F167941235: D21988.id63171.diff
	Tue, Aug 25, 1:11 PM

	Unknown Object (File)
	Sun, Aug 23, 4:06 AM

	Unknown Object (File)
	Thu, Aug 20, 8:55 AM

	Unknown Object (File)
	Tue, Aug 18, 12:10 PM

	Unknown Object (File)
	Mon, Aug 17, 5:31 PM

	Unknown Object (File)
	Sun, Aug 16, 2:45 PM

View All Files

Subscribers

imp

Details

Reviewers

jhibbits

Commits

rS353459: Fix read past end of struct in ncsw glue code.

Summary

This was causing panics for me when using GCC 6.4.

Replace overly clever code that was reading past the end of a struct with a basic double loop.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bdragon created this revision.Oct 12 2019, 1:13 AM

Herald added a subscriber: imp. · View Herald TranscriptOct 12 2019, 1:13 AM

bdragon retitled this revision from [PowerPC] Fix read past end of struct to [PowerPC] [BookE] Fix read past end of struct.Oct 12 2019, 1:14 AM

Looks good for what we can do for now. I really should clean up the whole DPAA interface bits, so we don't need to do that loop. But since it's only executed on bootup, it's not a very high priority task.

This revision is now accepted and ready to land.Oct 12 2019, 8:29 PM

Closed by commit rS353459: Fix read past end of struct in ncsw glue code. (authored by bdragon). · Explain WhyOct 12 2019, 11:16 PM

This revision was automatically updated to reflect the committed changes.

bdragon added a commit: rS353459: Fix read past end of struct in ncsw glue code..

Revision Contents
Changeset List

Path

Size

head/

sys/

contrib/

ncsw/

user/

env/

xx.c

14 lines

Diff 63204

View Options

head/sys/contrib/ncsw/user/env/xx.c

[PowerPC] [BookE] Fix read past end of structClosedPublicActions