Differential D2858

ddb: don't return undefined symbols to a lookup
ClosedPublic
Actions

Authored by markj on Jun 18 2015, 5:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jun 5, 6:59 PM

	Unknown Object (File)
	Thu, Jun 4, 7:57 AM

	Unknown Object (File)
	Wed, Jun 3, 10:16 PM

	Unknown Object (File)
	Sat, May 23, 12:41 AM

	Unknown Object (File)
	Apr 28 2026, 5:10 PM

	Unknown Object (File)
	Apr 28 2026, 5:05 PM

	Unknown Object (File)
	Apr 27 2026, 5:45 AM

	Unknown Object (File)
	Apr 24 2026, 10:26 AM

Subscribers

None

Details

Reviewers

peter
jhb

Commits

rS285774: Don't return undefined symbols to a DDB symbol lookup.

Summary

Undefined symbols have a value of 0, so it makes no sense to return such
a symbol when performing a lookup by value. This occurs when unwinding
the stack after calling a NULL function pointer, and we confusingly
report the current function as uart_sab82532_class() on amd64.

Convert db_print_loc_and_inst() to only attempt disassembly if we
managed to find a symbol corresponding to the IP. Otherwise we may fault
and reenter the debugger.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

markj updated this revision to Diff 6291.Jun 18 2015, 5:21 PM

markj retitled this revision from to ddb: don't return undefined symbols to a lookup.

markj edited the test plan for this revision. (Show Details)

markj updated this object.

markj added reviewers: peter, jhb.Jun 18 2015, 5:37 PM

jhb accepted this revision.Jun 20 2015, 2:22 PM

jhb edited edge metadata.

This revision is now accepted and ready to land.Jun 20 2015, 2:22 PM

Closed by commit rS285774: Don't return undefined symbols to a DDB symbol lookup. (authored by markj). · Explain WhyJul 21 2015, 11:08 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

ddb/

8 lines

2 lines

Diff 6291

sys/ddb/db_examine.c

Loading...

sys/ddb/db_main.c

Loading...