Page MenuHomeFreeBSD

ddb: don't return undefined symbols to a lookup
ClosedPublic

Authored by markj on Jun 18 2015, 5:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 12, 5:12 PM
Unknown Object (File)
Tue, Jan 7, 2:05 AM
Unknown Object (File)
Dec 1 2024, 3:44 PM
Unknown Object (File)
Nov 17 2024, 11:07 AM
Unknown Object (File)
Nov 17 2024, 5:38 AM
Unknown Object (File)
Oct 27 2024, 12:13 PM
Unknown Object (File)
Oct 25 2024, 9:10 PM
Unknown Object (File)
Oct 25 2024, 2:13 AM
Subscribers
None

Details

Summary

Undefined symbols have a value of 0, so it makes no sense to return such
a symbol when performing a lookup by value. This occurs when unwinding
the stack after calling a NULL function pointer, and we confusingly
report the current function as uart_sab82532_class() on amd64.

Convert db_print_loc_and_inst() to only attempt disassembly if we
managed to find a symbol corresponding to the IP. Otherwise we may fault
and reenter the debugger.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

markj retitled this revision from to ddb: don't return undefined symbols to a lookup.
markj edited the test plan for this revision. (Show Details)
markj updated this object.
jhb edited edge metadata.
This revision is now accepted and ready to land.Jun 20 2015, 2:22 PM
This revision was automatically updated to reflect the committed changes.