Page MenuHomeFreeBSD
Differential D2858

ddb: don't return undefined symbols to a lookup
ClosedPublic
Actions

Authored by markj on Jun 18 2015, 5:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jul 11, 12:14 AM
Unknown Object (File)
Wed, Jun 25, 10:34 AM
Unknown Object (File)
Tue, Jun 24, 4:29 AM
Unknown Object (File)
Sat, Jun 21, 7:13 PM
Unknown Object (File)
Fri, Jun 20, 3:11 PM
Unknown Object (File)
Thu, Jun 19, 5:38 PM
Unknown Object (File)
Jun 12 2025, 1:38 AM
Unknown Object (File)
Jun 8 2025, 8:15 AM
View All 99 Files
Subscribers
None

Details

Reviewers
peter
jhb
Commits
rS285774: Don't return undefined symbols to a DDB symbol lookup.
Summary

Undefined symbols have a value of 0, so it makes no sense to return such
a symbol when performing a lookup by value. This occurs when unwinding
the stack after calling a NULL function pointer, and we confusingly
report the current function as uart_sab82532_class() on amd64.

Convert db_print_loc_and_inst() to only attempt disassembly if we
managed to find a symbol corresponding to the IP. Otherwise we may fault
and reenter the debugger.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

markj updated this revision to Diff 6291.Jun 18 2015, 5:21 PM
markj retitled this revision from to ddb: don't return undefined symbols to a lookup.
markj edited the test plan for this revision. (Show Details)
markj updated this object.
markj added reviewers: peter, jhb.Jun 18 2015, 5:37 PM
jhb accepted this revision.Jun 20 2015, 2:22 PM
jhb edited edge metadata.
This revision is now accepted and ready to land.Jun 20 2015, 2:22 PM
Closed by commit rS285774: Don't return undefined symbols to a DDB symbol lookup. (authored by markj). · Explain WhyJul 21 2015, 11:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
ddb/
8 lines
2 lines

Diff 6291

View Options

sys/ddb/db_examine.c

Loading...
View Options

sys/ddb/db_main.c

Loading...