libusb: let LIBUSB_DEBUG environment variable override libusb_set_debug
ClosedPublic
Actions

Authored by kevans on Oct 2 2019, 1:43 PM.

Details

Reviewers

Commits

rS353009: libusb: LIBUSB_DEBUG environment variable override of libusb_set_debug

Summary

The debug level generally just controls verbosity of libusb for debugging libusb devices/usage. We allow the environment to set the debug level independent of the application, but the application will always override this if it explicitly sets the debug level.

Changing the environment is easy, but patching the software to change the debug level isn't necessarily easy or possible. Further, there's this write-only debug_fixed variable that would seem to imply that the debug level should be fixed, but it isn't currently used. Change the logic to use strtol() so we can detect real 0 vs. conversion failure, then honor debug_fixed in libusb_set_debug.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Oct 2 2019, 1:43 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 2 2019, 1:43 PM

Harbormaster completed remote builds in B26831: Diff 62829.Oct 2 2019, 1:43 PM

kevans edited the summary of this revision. (Show Details)Oct 2 2019, 1:47 PM

• hselasky added inline comments.Oct 2 2019, 2:07 PM

lib/libusb/libusb10.c
151 ↗	(On Diff #62829)	I think it is enough to check if *ep == '\0' ?

kevans added inline comments.Oct 2 2019, 2:12 PM

lib/libusb/libusb10.c
151 ↗	(On Diff #62829)	You have to check errno, too, because if you have all valid digits but simply hit overflow then *ep == '\0' but errno == ERANGE.