Page MenuHomeFreeBSD
Differential D21609

The porter's handbook Go chapter: update for D21562
ClosedPublic
Actions

Authored by dmgk on Sep 11 2019, 8:45 PM.
Tags
None
Referenced Files
F110350638: D21609.diff
Mon, Feb 17, 4:50 AM
Unknown Object (File)
Fri, Feb 14, 8:34 AM
Unknown Object (File)
Thu, Feb 13, 8:17 AM
Unknown Object (File)
Thu, Feb 13, 4:05 AM
Unknown Object (File)
Sun, Feb 9, 5:02 AM
Unknown Object (File)
Sat, Feb 8, 6:01 AM
Unknown Object (File)
Thu, Feb 6, 4:24 AM
Unknown Object (File)
Sat, Jan 25, 7:28 PM
View All 57 Files
Subscribers
bcr

Details

Reviewers
mat
tobik
bcr
Group Reviewers
Doc Committers
Commits
rD53409: Porter's Handbook: Document new GO_TARGET syntax
Summary

Document GO_TARGET tuple form, clarify that GO_PKGNAME is not needed in modules mode.

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 26408
Build 24864: arc lint + arc unit

Event Timeline

dmgk created this revision.Sep 11 2019, 8:45 PM
Herald added 1 blocking reviewer(s): mat. · View Herald TranscriptSep 11 2019, 8:45 PM
Harbormaster completed remote builds in B26408: Diff 61955.Sep 11 2019, 8:45 PM
tobik requested changes to this revision.Sep 12 2019, 11:48 AM
tobik added inline comments.
en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
1174

and seen by the <command>go</command>.

When reading this back out loud this sounds really weird to me and I do not think it adds much information. Can we drop it?

1178

s/Not needed/It is not needed/

1186

"The packages to build."

1191–1196

I think everything after "Specifying" would be better moved to one or more small concrete examples in 6.5.8. Building Go Applications.

This revision now requires changes to proceed.Sep 12 2019, 11:48 AM
dmgk added inline comments.Sep 12 2019, 12:16 PM
en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
1191–1196

If you could provide any help with examples, I'd appreciate it, documentation is not my strong suit :)

tobik added inline comments.Sep 12 2019, 12:27 PM
en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml
1191–1196

This can be something really simple like https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/building.html#cargo-ex2
maybe with the examples you have already given in the summary of D21562.

dmgk updated this revision to Diff 61978.Sep 12 2019, 3:03 PM

Update GO_PKGNAME description, add GO_TARGET tuple form examples.

Harbormaster completed remote builds in B26425: Diff 61978.Sep 12 2019, 3:03 PM
dmgk marked 4 inline comments as done.Sep 12 2019, 3:04 PM
tobik accepted this revision.EditedSep 14 2019, 8:26 AM

Looks ok to me, but one of the Doc Committers needs to approve.

tobik added a reviewer: Doc Committers.Sep 14 2019, 8:26 AM
bcr accepted this revision.Sep 15 2019, 10:27 AM
bcr added a subscriber: bcr.
In D21609#472006, @tobik wrote:

Looks ok to me, but one of the Doc Committers needs to approve.

Let me be the one: Approved! ;)

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2019, 11:32 AM
Closed by commit rD53409: Porter's Handbook: Document new GO_TARGET syntax (authored by tobik). · Explain Why
This revision was automatically updated to reflect the committed changes.
tobik added a commit: rD53409: Porter's Handbook: Document new GO_TARGET syntax.

Revision Contents
Changeset List

PathSize
en_US.ISO8859-1/
books/
porters-handbook/
uses/
30 lines

Diff 61955

View Options

en_US.ISO8859-1/books/porters-handbook/uses/chapter.xml

Loading...