Page MenuHomeFreeBSD
Differential D21599

locale: more output fixes
ClosedPublic
Actions

Authored by yuripv on Sep 10 2019, 9:28 PM.
Tags
None
Referenced Files
F133203111: D21599.id61936.diff
Thu, Oct 23, 10:41 PM
F133203110: D21599.id61919.diff
Thu, Oct 23, 10:41 PM
F133203108: D21599.id.diff
Thu, Oct 23, 10:41 PM
F133166142: D21599.diff
Thu, Oct 23, 2:14 PM
Unknown Object (File)
Wed, Oct 22, 5:41 PM
Unknown Object (File)
Sun, Oct 19, 1:31 AM
Unknown Object (File)
Sat, Oct 18, 6:41 PM
Unknown Object (File)
Thu, Oct 9, 9:18 PM
View All Files
Subscribers
imp

Details

Reviewers
bapt
Commits
rS352214: locale: more output fixes
Summary
  • make abday, day, abmon, mon, am_pm output quoting match linux
  • workaround localeconv() issue for mon_grouping and grouping (PR172215)
  • for other values not available in default locale, output -1 instead of 127 (CHAR_MAX) as returned by localeconv()

With these changes, output of locale and locale -k for all keywords
specified by POSIX exactly matches the linux one.

P.S. Baptiste, if I should include anyone else interested in reviewing locale stuff, please let me know.

Test Plan

New test cases provided, existing ones updated.

Compare the output of locale and locale -k for all POSIX specified keywords against linux.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yuripv created this revision.Sep 10 2019, 9:28 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 10 2019, 9:28 PM
bapt accepted this revision.Sep 11 2019, 7:24 AM

This looks fine to me, tested locally with success.

Note that I am fine with reviewing the locale patches and I am not sure anyone else is really interested into locale stuff :(

This revision is now accepted and ready to land.Sep 11 2019, 7:24 AM
Closed by commit rS352214: locale: more output fixes (authored by yuripv). · Explain WhySep 11 2019, 3:39 PM
This revision was automatically updated to reflect the committed changes.
yuripv added a commit: rS352214: locale: more output fixes.

Revision Contents
Changeset List

Diff 61936

View Options

head/usr.bin/locale/locale.c

Loading...
View Options

head/usr.bin/locale/tests/Makefile

Loading...
View Options

head/usr.bin/locale/tests/k_flag_posix_monetary.out

Loading...
View Options

head/usr.bin/locale/tests/k_flag_posix_numeric.out

Loading...
View Options

head/usr.bin/locale/tests/k_flag_posix_time.out

Loading...
View Options

head/usr.bin/locale/tests/locale_test.sh

Loading...
View Options

head/usr.bin/locale/tests/no_flags_posix_messages.out

Loading...
View Options

head/usr.bin/locale/tests/no_flags_posix_monetary.out

Loading...
View Options

head/usr.bin/locale/tests/no_flags_posix_numeric.out

Loading...
View Options

head/usr.bin/locale/tests/no_flags_posix_time.out

Loading...