Page MenuHomeFreeBSD
Differential D21526

[new port] x11/libXpresent/: X11 Present library
ClosedPublic
Actions

Authored by madpilot on Sep 4 2019, 8:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 20, 8:22 PM
Unknown Object (File)
Mon, May 20, 8:22 PM
Unknown Object (File)
Mon, May 20, 8:22 PM
Unknown Object (File)
Mon, May 20, 8:22 PM
Unknown Object (File)
Fri, May 17, 10:03 AM
Unknown Object (File)
Tue, May 14, 4:40 AM
Unknown Object (File)
Sat, May 11, 2:37 AM
Unknown Object (File)
Fri, Apr 26, 5:07 AM
View All 56 Files
Subscribers
mat
zeising

Details

Reviewers
zeising
Group Reviewers
x11
O5: Ports Framework
portmgr
Commits
rP511744: Add libXpresent:
Summary

I created this patch while upgrading XFCE to 4.14.

The xfce4-wm port, containing xfce window manager, can link to this library using it as a backend for vsync.

I'd like to add it to the ports tree, so that, after the XFCE upgrade, I can enable support for it to the window manager.

I set x11 as port maintainer, is this acceptable?

Related xfce review: D21278

Test Plan

I have tested it in poudriere with tier 1 platforms, and tested with the xfce window manager from D21278 after adapting the port to use it.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

madpilot created this revision.Sep 4 2019, 8:23 PM
Owners added a reviewer: O5: Ports Framework.Sep 4 2019, 8:23 PM
Herald added a reviewer: portmgr. · View Herald TranscriptSep 4 2019, 8:23 PM
Herald added a subscriber: mat. · View Herald Transcript
Harbormaster completed remote builds in B26279: Diff 61660.Sep 4 2019, 8:23 PM
madpilot edited the summary of this revision. (Show Details)Sep 4 2019, 8:24 PM
linimon retitled this revision from Add libXpresent X11 library to [new port] x11/libXpresent/: X11 Present library.Sep 6 2019, 12:06 AM
zeising requested changes to this revision.Sep 6 2019, 4:00 PM
zeising added a subscriber: zeising.
zeising added inline comments.
x11/libXpresent/Makefile
16 ↗(On Diff #61660)

Should be USES=xorg-cat:lib

This revision now requires changes to proceed.Sep 6 2019, 4:00 PM
madpilot marked an inline comment as done.Sep 6 2019, 7:33 PM
madpilot updated this revision to Diff 61758.Sep 6 2019, 7:33 PM

Fix USES.

Harbormaster completed remote builds in B26321: Diff 61758.Sep 6 2019, 7:33 PM
zeising accepted this revision.Sep 7 2019, 8:17 AM

Approved.
It makes sense to make the port owned by x11@
It doesn't need portmgr approval, Uses/xorg.mk is owned by x11@.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 10 2019, 7:11 AM
Closed by commit rP511744: Add libXpresent: (authored by madpilot). · Explain Why
This revision was automatically updated to reflect the committed changes.
madpilot added a commit: rP511744: Add libXpresent:.

Revision Contents
Changeset List

PathSizePackages
head/
Mk/
Uses/
2 linesO5: Ports Framework
x11/
1 line
libXpresent/
18 lines
3 lines
3 lines
7 lines

Diff 61871

View Options

head/Mk/Uses/xorg.mk

Loading...
View Options

head/x11/Makefile

Loading...
View Options

head/x11/libXpresent/Makefile

Loading...
View Options

head/x11/libXpresent/distinfo

Loading...
View Options

head/x11/libXpresent/pkg-descr

Loading...
View Options

head/x11/libXpresent/pkg-plist

Loading...