Page MenuHomeFreeBSD

procstat/tests: Fix flakiness by waiting for program to start
ClosedPublic

Authored by jilles on Sep 4 2019, 2:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 5, 4:07 AM
Unknown Object (File)
Tue, Jul 29, 1:15 AM
Unknown Object (File)
Mon, Jul 28, 1:09 PM
Unknown Object (File)
Jul 22 2025, 10:14 AM
Unknown Object (File)
Jul 21 2025, 12:09 PM
Unknown Object (File)
Jul 21 2025, 8:12 AM
Unknown Object (File)
Jul 21 2025, 8:10 AM
Unknown Object (File)
Jul 21 2025, 4:57 AM
Subscribers

Details

Summary

Some of the procstat tests start a program "while1" and examine the process
using procstat, but did not wait properly for it to start (kill -0 will
succeed immediately after the child process has been created).

Instead, have "while1" write something when it starts, and use a fifo to
wait for that.

PR: 233587, 233588

Test Plan

sh -c 'while kyua test; do :; done'
and let it continue for a while

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26273
Build 24759: arc lint + arc unit

Event Timeline

Remove no longer used variable MAX_TRIES

Thank you for fixing my flaky test (and for teaching me a new tidbit about shell support)!

This revision is now accepted and ready to land.Sep 4 2019, 2:20 PM