Page MenuHomeFreeBSD

procstat/tests: Fix flakiness by waiting for program to start
ClosedPublic

Authored by jilles on Sep 4 2019, 2:00 PM.
Tags
None
Referenced Files
F153023198: D21519.id.diff
Sat, Apr 18, 4:51 PM
F152982048: D21519.id61646.diff
Sat, Apr 18, 11:27 AM
Unknown Object (File)
Wed, Apr 15, 7:53 AM
Unknown Object (File)
Tue, Apr 7, 7:03 PM
Unknown Object (File)
Sun, Apr 5, 9:14 AM
Unknown Object (File)
Wed, Mar 25, 2:30 AM
Unknown Object (File)
Tue, Mar 24, 1:25 AM
Unknown Object (File)
Mar 20 2026, 12:23 AM
Subscribers

Details

Summary

Some of the procstat tests start a program "while1" and examine the process
using procstat, but did not wait properly for it to start (kill -0 will
succeed immediately after the child process has been created).

Instead, have "while1" write something when it starts, and use a fifo to
wait for that.

PR: 233587, 233588

Test Plan

sh -c 'while kyua test; do :; done'
and let it continue for a while

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 26272
Build 24758: arc lint + arc unit

Event Timeline

Remove no longer used variable MAX_TRIES

Thank you for fixing my flaky test (and for teaching me a new tidbit about shell support)!

This revision is now accepted and ready to land.Sep 4 2019, 2:20 PM