science/InsightToolkit: fix build with GCC-based architectures
ClosedPublic
Actions

Authored by pkubaj on Aug 27 2019, 8:07 AM.

Details

Reviewers

Commits

Summary

Compiling with GCC requires changes in pkg-plist.

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 26238
Build 24730: arc lint + arc unit

science/InsightToolkit/Makefile
58	should that be in compiler.mk ^^
science/InsightToolkit/pkg-plist
142	you could also do something like include/ITK-%%ITK_VER%%/compilers/ITK_COMPILER_INFO_%%CHOSEN_COMPILER_NAME%%_CXX.h and have `CHOSEN_COMPILER_NAME` added to the plist.

science/InsightToolkit/Makefile
58	Could be, but there are not many ports that need it.
science/InsightToolkit/pkg-plist
142	It won't work. When Clang is used, CHOSEN_COMPILER_NAME is clang (but the file has capital "c"). When GCC is used, CHOSEN_COMPILER_NAME is gcc (but the file has "Gnu" instead).

science/InsightToolkit/pkg-plist
142	I didn't mean adding the effective value to the plist, but just have a PLIST_SUB that contains either `Clang` or `GNU` depending on the chosen compiler.

Use a single PLIST_SUB.

Also remove the old patch that breaks build (even on amd64, it doesn't apply). It was introduced probably by mistake in https://svnweb.freebsd.org/ports?view=revision&revision=509864

pkubaj marked 2 inline comments as done.Sep 2 2019, 8:06 PM