science/InsightToolkit: fix build with GCC-based architectures

[pkubaj]

Summary

Compiling with GCC requires changes in pkg-plist.

[tcberner]

science/InsightToolkit/Makefile

58 ↗

(On Diff #61340)

should that be in compiler.mk ^^

science/InsightToolkit/pkg-plist

142 ↗

(On Diff #61340)

you could also do something like

include/ITK-%%ITK_VER%%/compilers/ITK_COMPILER_INFO_%%CHOSEN_COMPILER_NAME%%_CXX.h

and have CHOSEN_COMPILER_NAME added to the plist.

[pkubaj]

science/InsightToolkit/Makefile

58 ↗

(On Diff #61340)

Could be, but there are not many ports that need it.

science/InsightToolkit/pkg-plist

142 ↗

(On Diff #61340)

It won't work. When Clang is used, CHOSEN_COMPILER_NAME is clang (but the file has capital "c"). When GCC is used, CHOSEN_COMPILER_NAME is gcc (but the file has "Gnu" instead).

[tcberner]

science/InsightToolkit/pkg-plist

142 ↗

(On Diff #61340)

I didn't mean adding the effective value to the plist, but just have a PLIST_SUB that contains either Clang or GNU depending on the chosen compiler.

[pkubaj]

Use a single PLIST_SUB.

Also remove the old patch that breaks build (even on amd64, it doesn't apply). It was introduced probably by mistake in https://svnweb.freebsd.org/ports?view=revision&revision=509864

[tcberner]

In D21428#468142, @pkubaj wrote:

Use a single PLIST_SUB.

Thanks, this looks much cleaner to me

[pkubaj]

In D21428#468198, @tcberner wrote:

In D21428#468142, @pkubaj wrote:

Use a single PLIST_SUB.

Thanks, this looks much cleaner to me

Then is this ok?

[tcberner]

lgtm, yes.