Page MenuHomeFreeBSD
Differential D21285

graphics/photoflow: fix build on GCC architectures, don't optimize for builder CPU
ClosedPublic
Actions

Authored by pkubaj on Aug 16 2019, 1:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 5, 3:22 AM
Unknown Object (File)
Fri, Sep 4, 10:55 PM
Unknown Object (File)
Fri, Sep 4, 10:40 PM
Unknown Object (File)
Fri, Sep 4, 5:14 PM
Unknown Object (File)
Fri, Sep 4, 10:47 AM
Unknown Object (File)
Thu, Sep 3, 3:27 PM
Unknown Object (File)
Thu, Sep 3, 11:04 AM
Unknown Object (File)
Thu, Sep 3, 8:04 AM
View All Files
Subscribers
None

Details

Reviewers
linimon
mat
tcberner
Commits
rP510094: graphics/photoflow: fix build on GCC architectures, don't optimize for builder…
Summary

This port passes -march flags which are bad for users using packages.

Also merge https://github.com/aferrero2707/PhotoFlow/commit/0c79ee254eab9e4a44c7aeca9e43dc7990f14dd8#diff-2d5c4ed90f403ec79d56bb0af37dac07 and https://github.com/aferrero2707/PhotoFlow/commit/84c19b68d7a38dcf4877e7762303fb1841f33d3b#diff-2d5c4ed90f403ec79d56bb0af37dac07 for compatibility with GCC 9.

PR: 239833

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 26086
Build 24620: arc lint + arc unit

Event Timeline

pkubaj created this revision.Aug 16 2019, 1:53 AM
Harbormaster completed remote builds in B25905: Diff 60865.Aug 16 2019, 1:53 AM
mat added inline comments.Aug 19 2019, 12:03 PM
graphics/photoflow/Makefile
33

What does this do exactly?

pkubaj added inline comments.Aug 19 2019, 11:31 PM
graphics/photoflow/Makefile
33

Without this enabled, some staticly linked dependencies are optimized by default to the host CPU.

Since it's fine to do it when installing manually from the ports tree, I only disable it when using Poudriere.

mat added inline comments.Aug 20 2019, 10:28 AM
graphics/photoflow/Makefile
33

Then please add a comment saying so.

pkubaj updated this revision to Diff 61242.Aug 24 2019, 7:29 PM
pkubaj marked an inline comment as done.

Add a comment with explanation.

Harbormaster completed remote builds in B26086: Diff 61242.Aug 24 2019, 7:29 PM
linimon accepted this revision.Aug 27 2019, 10:13 PM
This revision is now accepted and ready to land.Aug 27 2019, 10:13 PM
Closed by commit rP510094: graphics/photoflow: fix build on GCC architectures, don't optimize for builder… (authored by pkubaj). · Explain WhyAug 28 2019, 7:25 PM
This revision was automatically updated to reflect the committed changes.
pkubaj added a commit: rP510094: graphics/photoflow: fix build on GCC architectures, don't optimize for builder….

Revision Contents
Changeset List

Diff 61242

View Options

graphics/photoflow/Makefile

Loading...
View Options

graphics/photoflow/files/patch-src_CMakeLists.txt

Loading...
View Options

graphics/photoflow/files/patch-src_external_rawspeed_src_librawspeed_common_Mutex.h

Loading...