ping6: Rename options for unifying option parsing with ping
ClosedPublic
Actions

Authored by jansucan on Aug 20 2019, 4:11 PM.

Details

Reviewers

asomers

Group Reviewers

manpages

Commits

rS351423: ping6: Rename options for better consistency with ping

Summary

Rename options for unifying option parsing with ping

The renaming is done so that names of equivalent options between ping and ping6 are the same, nonequivalent are different.

Submitted by: Ján Sučan <sucanjan@gmail.com>
Sponsored by: Google LLC (Google Summer of Code 2019)

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 26023
Build 24568: arc lint + arc unit

Event Timeline

jansucan created this revision.Aug 20 2019, 4:11 PM

Harbormaster completed remote builds in B25982: Diff 61052.Aug 20 2019, 4:11 PM

asomers requested changes to this revision.Aug 20 2019, 4:56 PM

asomers added inline comments.

sbin/ping6/ping6.8
32	You should update this date.
43	This line was sorted alphabetically before. You should try to keep it that way.
53	IPv6 hoplimit is functionally equivalent to IPv4 TTL, so they can use the same flag.
317	I suggest changing `-w` to `-y` to preserve the current symmetry between `-w` and `-W`. You would of course need to choose a different letter for "Generate ICMPv6 Note Information supported"
sbin/ping6/ping6.c
440	What was the base revision from which you generated this diff? There should've been a `case 'H'` here.

This revision now requires changes to proceed.Aug 20 2019, 4:56 PM

jansucan added inline comments.Aug 21 2019, 2:15 PM

sbin/ping6/ping6.c
440	I genereated this from my local git branch with D21338 applied.

Update date in the manual page.
Sort options in the SYNOPSIS section of the manual page alphabetically.
Use -m for hoplimit.
Change -w to -y.
Sort the getopt string alphabetically.
Sort options in the usage message alphabetically.
Reflect change of the -X option name to the test.

Harbormaster completed remote builds in B26023: Diff 61135.Aug 22 2019, 7:42 PM

jansucan added inline comments.Aug 22 2019, 7:45 PM

sbin/ping6/ping6.8
32	Fixed.
43	Fixed.
53	Fixed.
317	Fixed.

asomers accepted this revision.Aug 23 2019, 3:16 PM

This revision is now accepted and ready to land.Aug 23 2019, 3:16 PM

One more thing: you should normally add an entry in UPDATING letting people know that the options have changed so they can update their scripts. I'll go ahead and write it this time.

Closed by commit rS351423: ping6: Rename options for better consistency with ping (authored by asomers). · Explain WhyAug 23 2019, 3:22 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rS351423: ping6: Rename options for better consistency with ping.

Herald added a reviewer: manpages. · View Herald TranscriptAug 23 2019, 3:22 PM

Herald added a subscriber: imp. · View Herald Transcript